From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Enable non-contiguous pipe fusing
Date: Thu, 19 Mar 2020 18:06:37 +0200 [thread overview]
Message-ID: <20200319160637.GL13686@intel.com> (raw)
In-Reply-To: <20200319075317.GB11440@intel.com>
On Thu, Mar 19, 2020 at 01:23:18PM +0530, Anshuman Gupta wrote:
> On 2020-03-18 at 18:48:27 +0200, Ville Syrjälä wrote:
> > On Fri, Mar 13, 2020 at 12:39:17AM -0700, Lucas De Marchi wrote:
> > > On Wed, Mar 11, 2020 at 02:06:32PM +0530, Anshuman Gupta wrote:
> > > >Allow 3-display pipes SKU system with any combination
> > > >in INTEL_INFO pipe mask.
> > > >B.Spec:50075
> > > >
> > > >changes since RFC:
> > > >- using intel_pipe_mask_is_valid() function to check integrity of
> > > > pipe_mask. [Ville]
> > > >v2:
> > > >- simplify condition in intel_pipe_mask_is_valid(). [Ville]
> > > >v3:
> > > >- removed non-contiguous pipe fusing check. [Lucas]
> > >
> > > I'd also say in the commit message that the support for non-contiguous
> > > pipe fusing is *already* supported in the driver. So this check here
> > > doesn't make sense anymore and since it's an unlike condition we
> > > can just stop checking.
> >
> > BTW I think we still have those crtc index==pipe asserts in the code
> > somewhere. Now that all the (known) assumptions have been fixed we can
> > remove the WARNs.
> yes we still have drm_WARN_ON(&dev_priv->drm, drm_crtc_index(&crtc->base) != crtc->pipe)
> in intel_crtc_init.
> AFAIU the idea was to have the WARN_ON to know that we are running a broken driver
> (if there any unknown assumption is still left out).
Unknown assumptions are by definition unknown. The WARN will not help
with those.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-19 16:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 8:36 [Intel-gfx] [PATCH] drm/i915: Enable non-contiguous pipe fusing Anshuman Gupta
2020-03-11 10:02 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-03-12 11:08 ` Anshuman Gupta
2020-03-12 11:39 ` Vudum, Lakshminarayana
2020-03-12 11:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-13 4:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-13 7:39 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2020-03-18 16:48 ` Ville Syrjälä
2020-03-19 7:53 ` Anshuman Gupta
2020-03-19 16:06 ` Ville Syrjälä [this message]
2020-03-18 9:44 ` [Intel-gfx] [PATCH v3] " Anshuman Gupta
2020-03-18 10:22 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319160637.GL13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.