From: Greg KH <gregkh@linuxfoundation.org>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/2] Avoid multiple line dereference
Date: Fri, 20 Mar 2020 07:59:50 +0100 [thread overview]
Message-ID: <20200320065950.GC307955@kroah.com> (raw)
In-Reply-To: <20200320065906.GB307955@kroah.com>
On Fri, Mar 20, 2020 at 07:59:06AM +0100, Greg KH wrote:
> On Fri, Mar 20, 2020 at 05:03:03AM +0300, Gokce Kuler wrote:
> > merge a line -> with a line ending with a sign
> >
> > merge a line -> with a line ending with a sign
> >
> > Gokce Kuler (2):
> > staging: rtl8712: Avoid multiple line dereference
> > staging: rtl8712: Avoid multiple line dereference
>
> You should put the subsystem and driver in this 0/2 email subject as
> well.
>
> But the big problem of this (have you been reading other patch
> submissions here?) is that you sent 2 patches that did different things,
> yet had the same subject line, which is not ok.
>
> Please make them unique.
And why is this 2 patches anyway? SHouldn't it just be 1 patch as you
are doing 1 logical thing to the file?
Do not make multiple patches were a single one is all that is needed.
thanks,
greg k-h
prev parent reply other threads:[~2020-03-20 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 2:03 [PATCH 0/2] Avoid multiple line dereference Gokce Kuler
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
2020-03-20 9:19 ` Sergei Shtylyov
2020-03-20 2:03 ` [PATCH 2/2] " Gokce Kuler
2020-03-20 6:59 ` [PATCH 0/2] " Greg KH
2020-03-20 6:59 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320065950.GC307955@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gokcekuler@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.