From: Dan Carpenter <dan.carpenter@oracle.com>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
Derek Chickles <dchickles@marvell.com>,
"David S . Miller" <davem@davemloft.net>,
Satanand Burla <sburla@marvell.com>,
Felix Manlunas <fmanlunas@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] liquidio: remove set but not used variable 's'
Date: Fri, 20 Mar 2020 13:14:29 +0000 [thread overview]
Message-ID: <20200320131429.GH4650@kadam> (raw)
In-Reply-To: <20200319121035.GO126814@unreal>
On Thu, Mar 19, 2020 at 02:10:35PM +0200, Leon Romanovsky wrote:
> On Thu, Mar 19, 2020 at 12:07:43PM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_chip_specific_setup':
> > drivers/net/ethernet/cavium/liquidio/lio_main.c:1378:8: warning:
> > variable 's' set but not used [-Wunused-but-set-variable]
> >
> > It's not used since commit b6334be64d6f ("net/liquidio: Delete driver version assignment")
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
>
> I'm sorry for missing this warning.
>
The warning is not enabled by default.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Leon Romanovsky <leonro@mellanox.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
Derek Chickles <dchickles@marvell.com>,
"David S . Miller" <davem@davemloft.net>,
Satanand Burla <sburla@marvell.com>,
Felix Manlunas <fmanlunas@marvell.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] liquidio: remove set but not used variable 's'
Date: Fri, 20 Mar 2020 06:14:29 -0700 (PDT) [thread overview]
Message-ID: <20200320131429.GH4650@kadam> (raw)
In-Reply-To: <20200319121035.GO126814@unreal>
On Thu, Mar 19, 2020 at 02:10:35PM +0200, Leon Romanovsky wrote:
> On Thu, Mar 19, 2020 at 12:07:43PM +0000, YueHaibing wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > drivers/net/ethernet/cavium/liquidio/lio_main.c: In function 'octeon_chip_specific_setup':
> > drivers/net/ethernet/cavium/liquidio/lio_main.c:1378:8: warning:
> > variable 's' set but not used [-Wunused-but-set-variable]
> >
> > It's not used since commit b6334be64d6f ("net/liquidio: Delete driver version assignment")
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
>
> I'm sorry for missing this warning.
>
The warning is not enabled by default.
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-20 13:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306023254.61731-1-yuehaibing@huawei.com>
2020-03-19 12:07 ` [PATCH net-next] liquidio: remove set but not used variable 's' YueHaibing
2020-03-19 12:07 ` YueHaibing
2020-03-19 12:10 ` Leon Romanovsky
2020-03-19 12:10 ` Leon Romanovsky
2020-03-20 13:14 ` Dan Carpenter [this message]
2020-03-20 13:14 ` Dan Carpenter
2020-03-20 4:00 ` David Miller
2020-03-20 4:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320131429.GH4650@kadam \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=fmanlunas@marvell.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sburla@marvell.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.