* [PATCH v2 1/2] staging: rtl8723bs: os_dep: Correct long line comments
2020-03-20 1:47 [PATCH v2 0/2] staging: rtl8723bs: os_dep: Correct long line comments and remove whitespace in code R Veera Kumar
@ 2020-03-20 1:47 ` R Veera Kumar
2020-03-20 14:06 ` Greg Kroah-Hartman
2020-03-20 1:47 ` [PATCH v2 2/2] staging: rtl8723bs: os_dep: Remove whitespace characters in code line R Veera Kumar
1 sibling, 1 reply; 5+ messages in thread
From: R Veera Kumar @ 2020-03-20 1:47 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: R Veera Kumar, outreachy-kernel
Correct long line comments to respect 80 character per
line limit.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v3:
- Remove extra ' ' character before comment
Changes in v2:
- Remove an extra blank line added by error
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 26 ++++++++++++++-----
1 file changed, 20 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index a6491f163272..87090af7d776 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -35,7 +35,8 @@ void rtw_os_recv_resource_free(struct recv_priv *precvpriv)
for (i = 0; i < NR_RECVFRAME; i++) {
if (precvframe->u.hdr.pkt) {
- dev_kfree_skb_any(precvframe->u.hdr.pkt);/* free skb by driver */
+ /* free skb by driver */
+ dev_kfree_skb_any(precvframe->u.hdr.pkt);
precvframe->u.hdr.pkt = NULL;
}
precvframe++;
@@ -80,7 +81,10 @@ _pkt *rtw_os_alloc_msdu_pkt(union recv_frame *prframe, u16 nSubframe_Length, u8
((!memcmp(sub_skb->data, rtw_rfc1042_header, SNAP_SIZE) &&
eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
!memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
- /* remove RFC1042 or Bridge-Tunnel encapsulation and replace EtherType */
+ /*
+ * remove RFC1042 or Bridge-Tunnel encapsulation and replace
+ * EtherType
+ */
skb_pull(sub_skb, SNAP_SIZE);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src, ETH_ALEN);
memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst, ETH_ALEN);
@@ -112,7 +116,10 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
/* DBG_871X("bmcast =%d\n", bmcast); */
if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
- /* DBG_871X("not ap psta =%p, addr =%pM\n", psta, pattrib->dst); */
+ /*
+ * DBG_871X("not ap psta =%p, addr =%pM\n",
+ * psta, pattrib->dst);
+ */
if (bmcast) {
psta = rtw_get_bcmc_stainfo(padapter);
@@ -124,7 +131,10 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
if (psta) {
struct net_device *pnetdev = (struct net_device*)padapter->pnetdev;
- /* DBG_871X("directly forwarding to the rtw_xmit_entry\n"); */
+ /*
+ * DBG_871X("directly forwarding to the
+ * rtw_xmit_entry\n");
+ */
/* skb->ip_summed = CHECKSUM_NONE; */
pkt->dev = pnetdev;
@@ -236,7 +246,10 @@ static void rtw_os_ksocket_send(struct adapter *padapter, union recv_frame *prec
u16 len = *(u16*)(skb->data+ETH_HLEN+2);
/* u16 ctrl_type = *(u16*)(skb->data+ETH_HLEN+4); */
- /* DBG_871X("eth, RC: len = 0x%x, ctrl_type = 0x%x\n", len, ctrl_type); */
+ /*
+ * DBG_871X("eth, RC: len = 0x%x, ctrl_type = 0x%x\n",
+ * len, ctrl_type);
+ */
DBG_871X("eth, RC: len = 0x%x\n", len);
for (i = 0; i < len; i++)
@@ -291,7 +304,8 @@ int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame *precv_frame
rtw_os_recv_indicate_pkt(padapter, skb, pattrib);
- precv_frame->u.hdr.pkt = NULL; /* pointers to NULL before rtw_free_recvframe() */
+ /* pointers to NULL before rtw_free_recvframe() */
+ precv_frame->u.hdr.pkt = NULL;
rtw_free_recvframe(precv_frame, pfree_recv_queue);
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/2] staging: rtl8723bs: os_dep: Remove whitespace characters in code line
2020-03-20 1:47 [PATCH v2 0/2] staging: rtl8723bs: os_dep: Correct long line comments and remove whitespace in code R Veera Kumar
2020-03-20 1:47 ` [PATCH v2 1/2] staging: rtl8723bs: os_dep: Correct long line comments R Veera Kumar
@ 2020-03-20 1:47 ` R Veera Kumar
2020-03-20 14:06 ` Greg Kroah-Hartman
1 sibling, 1 reply; 5+ messages in thread
From: R Veera Kumar @ 2020-03-20 1:47 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: R Veera Kumar, outreachy-kernel
Remove five leading whitespace characters in code line.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8723bs/os_dep/recv_linux.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index 87090af7d776..1502477e48bb 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -79,8 +79,8 @@ _pkt *rtw_os_alloc_msdu_pkt(union recv_frame *prframe, u16 nSubframe_Length, u8
if (sub_skb->len >= 8 &&
((!memcmp(sub_skb->data, rtw_rfc1042_header, SNAP_SIZE) &&
- eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
- !memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
+ eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
+ !memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
/*
* remove RFC1042 or Bridge-Tunnel encapsulation and replace
* EtherType
@@ -315,11 +315,11 @@ int rtw_recv_indicatepkt(struct adapter *padapter, union recv_frame *precv_frame
_recv_indicatepkt_drop:
- /* enqueue back to free_recv_queue */
- rtw_free_recvframe(precv_frame, pfree_recv_queue);
+ /* enqueue back to free_recv_queue */
+ rtw_free_recvframe(precv_frame, pfree_recv_queue);
- DBG_COUNTER(padapter->rx_logs.os_indicate_err);
- return _FAIL;
+ DBG_COUNTER(padapter->rx_logs.os_indicate_err);
+ return _FAIL;
}
void rtw_init_recv_timer(struct recv_reorder_ctrl *preorder_ctrl)
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread