From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Paul Blakey <paulb@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Roi Dayan <roid@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Fix actions_match_supported() return
Date: Fri, 20 Mar 2020 14:33:00 +0000 [thread overview]
Message-ID: <20200320143300.GH514123@unreal> (raw)
In-Reply-To: <20200320132305.GB95012@mwanda>
On Fri, Mar 20, 2020 at 04:23:05PM +0300, Dan Carpenter wrote:
> The actions_match_supported() function returns a bool, true for success
> and false for failure. This error path is returning a negative which
> is cast to true but it should return false.
>
> Fixes: 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
Paul Blakey <paulb@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Roi Dayan <roid@mellanox.com>, Oz Shlomo <ozsh@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Fix actions_match_supported() return
Date: Fri, 20 Mar 2020 16:33:00 +0200 [thread overview]
Message-ID: <20200320143300.GH514123@unreal> (raw)
In-Reply-To: <20200320132305.GB95012@mwanda>
On Fri, Mar 20, 2020 at 04:23:05PM +0300, Dan Carpenter wrote:
> The actions_match_supported() function returns a bool, true for success
> and false for failure. This error path is returning a negative which
> is cast to true but it should return false.
>
> Fixes: 4c3844d9e97e ("net/mlx5e: CT: Introduce connection tracking")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
next prev parent reply other threads:[~2020-03-20 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 13:23 [PATCH net-next] net/mlx5e: Fix actions_match_supported() return Dan Carpenter
2020-03-20 13:23 ` Dan Carpenter
2020-03-20 14:33 ` Leon Romanovsky [this message]
2020-03-20 14:33 ` Leon Romanovsky
2020-03-21 2:43 ` Saeed Mahameed
2020-03-21 2:43 ` Saeed Mahameed
2020-03-23 10:02 ` Dan Carpenter
2020-03-23 10:02 ` Dan Carpenter
2020-03-23 17:01 ` Jakub Kicinski
2020-03-23 17:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320143300.GH514123@unreal \
--to=leon@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.