From: Thierry Reding <thierry.reding@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: ldewangan@nvidia.com, jonathanh@nvidia.com,
dan.j.williams@intel.com, vkoul@kernel.org,
swarren@wwwdotorg.org, dmaengine@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
digetx@gmail.com
Subject: Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
Date: Fri, 20 Mar 2020 16:11:10 +0100 [thread overview]
Message-ID: <20200320151110.GC3706404@ulmo> (raw)
In-Reply-To: <20200320071337.59756-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
Date: Fri, 20 Mar 2020 16:11:10 +0100 [thread overview]
Message-ID: <20200320151110.GC3706404@ulmo> (raw)
In-Reply-To: <20200320071337.59756-1-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/dma/tegra20-apb-dma.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-20 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
2020-03-20 7:13 ` YueHaibing
2020-03-20 14:25 ` Dmitry Osipenko
2020-03-20 15:11 ` Thierry Reding [this message]
2020-03-20 15:11 ` Thierry Reding
2020-03-23 6:30 ` Vinod Koul
2020-03-23 6:30 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320151110.GC3706404@ulmo \
--to=thierry.reding@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=digetx@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.