From: R Veera Kumar <vkor@vkten.in>
To: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH 2/2] staging: rtl8723bs: os_dep: Remove whitespace characters in code line
Date: Fri, 20 Mar 2020 22:19:02 +0530 [thread overview]
Message-ID: <20200320164858.GA6721@tulip.local> (raw)
In-Reply-To: <20200320140558.GB643325@kroah.com>
On Fri, Mar 20, 2020 at 03:05:58PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 20, 2020 at 07:08:23AM +0530, R Veera Kumar wrote:
> > Remove five leading whitespace characters in code line.
> >
> > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > ---
> > drivers/staging/rtl8723bs/os_dep/recv_linux.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > index 87090af7d776..1502477e48bb 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > @@ -79,8 +79,8 @@ _pkt *rtw_os_alloc_msdu_pkt(union recv_frame *prframe, u16 nSubframe_Length, u8
> >
> > if (sub_skb->len >= 8 &&
> > ((!memcmp(sub_skb->data, rtw_rfc1042_header, SNAP_SIZE) &&
> > - eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
> > - !memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
> > + eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
> > + !memcmp(sub_skb->data, rtw_bridge_tunnel_header, SNAP_SIZE))) {
>
> No, the original was correct here, checkpatch should not have complained
> about this.
>
This is V1 patch. I removed a single white space before "eth_type !=" as
definitely it is compound argument code.
Please see V2 patch. In which Greg says this is fine.
Should final comment by him is to be accepted?
Veera
> thanks,
>
> greg k-h
prev parent reply other threads:[~2020-03-20 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 1:38 [PATCH 0/2] Correct long line comments and remove whitespace in code R Veera Kumar
2020-03-20 1:38 ` [PATCH 1/2] staging: rtl8723bs: os_dep: Correct long line comments R Veera Kumar
2020-03-20 14:05 ` Greg Kroah-Hartman
2020-03-21 2:14 ` R Veera Kumar
2020-03-21 7:35 ` [Outreachy kernel] " Julia Lawall
2020-03-20 1:38 ` [PATCH 2/2] staging: rtl8723bs: os_dep: Remove whitespace characters in code line R Veera Kumar
2020-03-20 14:05 ` Greg Kroah-Hartman
2020-03-20 16:49 ` R Veera Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320164858.GA6721@tulip.local \
--to=vkor@vkten.in \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.