Re: [PATCH 1/2] staging: rtl8723bs: os_dep: Correct long line comments

[R Veera Kumar <vkor@vkten.in>]

On Fri, Mar 20, 2020 at 03:05:16PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 20, 2020 at 07:08:22AM +0530, R Veera Kumar wrote:
> > Correct long line comments to respect 80 character per
> > line limit.
> > 
> > diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > index a6491f163272..87090af7d776 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > @@ -35,7 +35,8 @@ void rtw_os_recv_resource_free(struct recv_priv *precvpriv)
> >  
> >  			if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
> > -				/* DBG_871X("not ap psta =%p, addr =%pM\n", psta, pattrib->dst); */
> > +				/*
> > +				 * DBG_871X("not ap psta =%p, addr =%pM\n",
> > +				 * psta, pattrib->dst);
> 
> Again, this is not a long-line comment, it is a code line that is
> commented out.  Remove it in a patch previous to this one please.
>

Okay I understand now that it is not a valid comment describing how
it functions.

But is not that the developers intention was to keep this to remind
him of doing something.

Or should he should have kept in his codebase and not here.

Also should I create a patch to remove this commented out code lines
in the same patch series or a new one.

Veera

> > +				 */
> >  
> >  				if (bmcast) {
> >  					psta = rtw_get_bcmc_stainfo(padapter);
> > @@ -124,7 +131,10 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
> >  				if (psta) {
> >  					struct net_device *pnetdev = (struct net_device*)padapter->pnetdev;
> >  
> > -					/* DBG_871X("directly forwarding to the rtw_xmit_entry\n"); */
> > +					/*
> > +					 * DBG_871X("directly forwarding to the
> > +					 * rtw_xmit_entry\n");
> 
> Same here.
> 
> thanks,
> 
> greg k-h