Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8723bs: os_dep: Remove commented out code lines

[R Veera Kumar <vkor@vkten.in>]

On Sat, Mar 21, 2020 at 08:32:49AM +0100, Julia Lawall wrote:
> 
> 
> On Sat, 21 Mar 2020, R Veera Kumar wrote:
> 
> > Remove multiple commented out code lines.
> > Remove blank lines next to them.
> 
> You don't have the change it, but mentioning removing the blank lines was
> not really necessary.  It is normal that you should clean up the
> adjacent whitespace when you clean up the code.
> 

Sorry I can't make out: "You don't have the change it"

So I keep those commented lines or remove them.

But Greg said in comment to patch:
Again, this is not a long-line comment, it is a code line that is
commented out. "Remove it in a patch previous to this one please."

Veera

> julia
> 
> >
> > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > ---
> >  drivers/staging/rtl8723bs/os_dep/recv_linux.c | 11 -----------
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > index a6491f163272..271b680e4388 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > @@ -109,11 +109,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
> >  			struct sta_priv *pstapriv = &padapter->stapriv;
> >  			int bmcast = IS_MCAST(pattrib->dst);
> >
> > -			/* DBG_871X("bmcast =%d\n", bmcast); */
> > -
> >  			if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
> > -				/* DBG_871X("not ap psta =%p, addr =%pM\n", psta, pattrib->dst); */
> > -
> >  				if (bmcast) {
> >  					psta = rtw_get_bcmc_stainfo(padapter);
> >  					pskb2 = rtw_skb_clone(pkt);
> > @@ -123,9 +119,6 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
> >
> >  				if (psta) {
> >  					struct net_device *pnetdev = (struct net_device*)padapter->pnetdev;
> > -
> > -					/* DBG_871X("directly forwarding to the rtw_xmit_entry\n"); */
> > -
> >  					/* skb->ip_summed = CHECKSUM_NONE; */
> >  					pkt->dev = pnetdev;
> >  					skb_set_queue_mapping(pkt, rtw_recv_select_queue(pkt));
> > @@ -234,14 +227,10 @@ static void rtw_os_ksocket_send(struct adapter *padapter, union recv_frame *prec
> >  		if (rx_pid == psta->pid) {
> >  			int i;
> >  			u16 len = *(u16*)(skb->data+ETH_HLEN+2);
> > -			/* u16 ctrl_type = *(u16*)(skb->data+ETH_HLEN+4); */
> > -
> > -			/* DBG_871X("eth, RC: len = 0x%x, ctrl_type = 0x%x\n", len, ctrl_type); */
> >  			DBG_871X("eth, RC: len = 0x%x\n", len);
> >
> >  			for (i = 0; i < len; i++)
> >  				DBG_871X("0x%x\n", *(skb->data+ETH_HLEN+4+i));
> > -				/* DBG_871X("0x%x\n", *(skb->data+ETH_HLEN+6+i)); */
> >
> >  			DBG_871X("eth, RC-end\n");
> >  		}
> > --