From: R Veera Kumar <vkor@vkten.in>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH v3 1/3] staging: rtl8723bs: os_dep: Remove commented out code lines
Date: Sat, 21 Mar 2020 14:40:26 +0530 [thread overview]
Message-ID: <20200321091018.GA1978@tulip.local> (raw)
In-Reply-To: <alpine.DEB.2.21.2003210945070.2522@hadrien>
On Sat, Mar 21, 2020 at 09:46:01AM +0100, Julia Lawall wrote:
> On Sat, 21 Mar 2020, R Veera Kumar wrote:
>
> > On Sat, Mar 21, 2020 at 08:32:49AM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Sat, 21 Mar 2020, R Veera Kumar wrote:
> > >
> > > > Remove multiple commented out code lines.
> > > > Remove blank lines next to them.
> > >
> > > You don't have the change it, but mentioning removing the blank lines was
> > > not really necessary. It is normal that you should clean up the
> > > adjacent whitespace when you clean up the code.
> > >
> >
> > Sorry I can't make out: "You don't have the change it"
> >
> > So I keep those commented lines or remove them.
>
> I was commenting on your log message, not on your changes.
>
> There was no need to include "Remove blank lines next to them." in the log
> message.
>
Okay.
Since that log msg is going to be included in git repo commit log,
do I have to remove it and send a new patchset revision.
Veera
> julia
>
> >
> > But Greg said in comment to patch:
> > Again, this is not a long-line comment, it is a code line that is
> > commented out. "Remove it in a patch previous to this one please."
> >
> > Veera
> >
> > > julia
> > >
next prev parent reply other threads:[~2020-03-21 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 4:38 [PATCH v3 0/3] staging: rtl8723bs: os_dep: Remove commented code lines, correct longline comments, remove whitespace in code R Veera Kumar
2020-03-21 4:38 ` [PATCH v3 1/3] staging: rtl8723bs: os_dep: Remove commented out code lines R Veera Kumar
2020-03-21 7:32 ` [Outreachy kernel] " Julia Lawall
2020-03-21 8:07 ` R Veera Kumar
2020-03-21 8:46 ` Julia Lawall
2020-03-21 9:10 ` R Veera Kumar [this message]
2020-03-21 9:11 ` Julia Lawall
2020-03-21 4:38 ` [PATCH v3 2/3] staging: rtl8723bs: os_dep: Correct long line comments R Veera Kumar
2020-03-21 4:38 ` [PATCH v3 3/3] staging: rtl8723bs: os_dep: Remove whitespace characters in code line R Veera Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321091018.GA1978@tulip.local \
--to=vkor@vkten.in \
--cc=julia.lawall@inria.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.