From: Greg KH <gregkh@linuxfoundation.org>
To: Sam Muhammed <jane.pnx9@gmail.com>
Cc: Gokce Kuler <gokcekuler@gmail.com>, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line
Date: Sat, 21 Mar 2020 13:46:15 +0100 [thread overview]
Message-ID: <20200321124615.GA1215294@kroah.com> (raw)
In-Reply-To: <e60514a251eb3f690e9136670def0ee2b8289969.camel@gmail.com>
On Sat, Mar 21, 2020 at 08:44:48AM -0400, Sam Muhammed wrote:
> On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote:
> > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote:
> > > Moved to the bottom line */ for block comments
> >
> > Again, you said what you did, but not why.
> >
> > Also, you _added_ two new checkpatch warnings, not a good ratio :(
> >
> > thanks,
> >
>
> Iam sorry, are we allowed to work on this driver, because i got;
> WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the
> MAINTAINERS hierarchy. No unnecessary modifications please.
For basic code cleanups, to learn the process, it's fine, but note that
the code will be deleted from the kernel "soon", so any changes you make
will not stick around.
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-21 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 1:31 [PATCH] staging: hp100: Block comments use a trailing */ on a separate line Gokce Kuler
2020-03-21 9:33 ` Greg KH
2020-03-21 12:44 ` [Outreachy kernel] " Sam Muhammed
2020-03-21 12:46 ` Greg KH [this message]
2020-03-21 12:50 ` Sam Muhammed
2020-03-21 13:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321124615.GA1215294@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=gokcekuler@gmail.com \
--cc=jane.pnx9@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.