Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 21, 2020 at 08:50:49AM -0400, Sam Muhammed wrote:
> On Sat, 2020-03-21 at 13:46 +0100, Greg KH wrote:
> > On Sat, Mar 21, 2020 at 08:44:48AM -0400, Sam Muhammed wrote:
> > > On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote:
> > > > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote:
> > > > > Moved to the bottom line */ for block comments
> > > > 
> > > > Again, you said what you did, but not why.
> > > > 
> > > > Also, you _added_ two new checkpatch warnings, not a good ratio :(
> > > > 
> > > > thanks,
> > > > 
> > > 
> > > Iam sorry, are we allowed to work on this driver, because i got; 
> > > WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the
> > > MAINTAINERS hierarchy.  No unnecessary modifications please.
> > 
> > For basic code cleanups, to learn the process, it's fine, but note that
> > the code will be deleted from the kernel "soon", so any changes you make
> > will not stick around.
> > 
> 
> So outreachy-wise, would this be considered as a contribution?
> This driver is juicy :)

Sure, I'll take contributions to it until Wednesday, and then I'll
delete it from the tree as it's about time it needs to go.

thanks,

greg k-h