* [PATCH] staging: hp100: Remove unnecessary braces
@ 2020-03-22 0:34 Gokce Kuler
2020-03-22 7:59 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-22 0:34 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove unnecessary braces for single statement block
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/hp/hp100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 6041043..61b891d 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -2788,9 +2788,9 @@ void hp100_RegisterDump(struct net_device *dev)
outw(Page, ioaddr + 0x02);
for (Register = 0x8; Register < 0x22; Register += 2) {
/* Display Register contents except data port */
- if (((Register != 0x10) && (Register != 0x12)) || (Page > 0)) {
+ if (((Register != 0x10) && (Register != 0x12)) || (Page > 0))
printk("0x%.2x = 0x%.4x\n", Register, inw(ioaddr + Register));
- }
+
}
}
hp100_page(PERFORMANCE);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: hp100: Remove unnecessary braces
2020-03-22 0:34 [PATCH] staging: hp100: Remove unnecessary braces Gokce Kuler
@ 2020-03-22 7:59 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2020-03-22 7:59 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Sun, 22 Mar 2020, Gokce Kuler wrote:
> Remove unnecessary braces for single statement block
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index 6041043..61b891d 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -2788,9 +2788,9 @@ void hp100_RegisterDump(struct net_device *dev)
> outw(Page, ioaddr + 0x02);
> for (Register = 0x8; Register < 0x22; Register += 2) {
> /* Display Register contents except data port */
> - if (((Register != 0x10) && (Register != 0x12)) || (Page > 0)) {
> + if (((Register != 0x10) && (Register != 0x12)) || (Page > 0))
> printk("0x%.2x = 0x%.4x\n", Register, inw(ioaddr + Register));
> - }
> +
There is no need to add a blank line here.
julia
> }
> }
> hp100_page(PERFORMANCE);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322003441.GA847%40siyah2.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-22 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-22 0:34 [PATCH] staging: hp100: Remove unnecessary braces Gokce Kuler
2020-03-22 7:59 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.