[PATCH] staging: hp100: rearrange line exceeding 80 characters

[PATCH] staging: hp100: rearrange line exceeding 80 characters

[Gokce Kuler]

moved to the bottom line after && operator for it exceeds 80 character

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/hp/hp100.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 61b891d..8aadb5b 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -1407,7 +1407,8 @@ static void hp100_BM_shutdown(struct net_device *dev)
 			for (time = 0; time < 10000; time++) {
 				/* RX_PDL: PDLs not executed. */
 				/* RX_PKT_CNT: RX'd packets on card. */
-				if ((hp100_inb(RX_PDL) == 0) && (hp100_inb(RX_PKT_CNT) == 0))
+				if ((hp100_inb(RX_PDL) == 0) &&
+			       	    (hp100_inb(RX_PKT_CNT) == 0))
 					break;
 			}
 
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: hp100: rearrange line exceeding 80 characters

[Julia Lawall]

On Sun, 22 Mar 2020, Gokce Kuler wrote:

> moved to the bottom line after && operator for it exceeds 80 character

Sentences need to begin with a capital letter and end with a period.  It
may seem picky, but in an open source setting, this is the only form of
communication available, so things need to be done in an expected way.

Maybe the tests could be rewritten with ! and then the whole thing could
stay on one line.

julia

>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/hp/hp100.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index 61b891d..8aadb5b 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -1407,7 +1407,8 @@ static void hp100_BM_shutdown(struct net_device *dev)
>  			for (time = 0; time < 10000; time++) {
>  				/* RX_PDL: PDLs not executed. */
>  				/* RX_PKT_CNT: RX'd packets on card. */
> -				if ((hp100_inb(RX_PDL) == 0) && (hp100_inb(RX_PKT_CNT) == 0))
> +				if ((hp100_inb(RX_PDL) == 0) &&
> +			       	    (hp100_inb(RX_PKT_CNT) == 0))
>  					break;
>  			}
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322011612.GA4357%40siyah2.
>