[PATCH] staging: hp100: braces {} are not necessary for single statement blocks

[PATCH] staging: hp100: braces {} are not necessary for single statement blocks

[Gokce Kuler]

Remove unnecessary braces for single statement block

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/hp/hp100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 8aadb5b..1b957aa 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -1332,9 +1332,9 @@ static void hp100_rxfill(struct net_device *dev)
 		   ** Attempt to get a buffer and build a Rx PDL.
 		 */
 		ringptr = lp->rxrtail;
-		if (0 == hp100_build_rx_pdl(ringptr, dev)) {
+		if (0 == hp100_build_rx_pdl(ringptr, dev)) 
 			return;	/* None available, return */
-		}
+		
 
 		/* Hand this PDL over to the card */
 		/* Note: This needs performance page selected! */
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: hp100: braces {} are not necessary for single statement blocks

[Julia Lawall]

On Sun, 22 Mar 2020, Gokce Kuler wrote:

> Remove unnecessary braces for single statement block
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/hp/hp100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index 8aadb5b..1b957aa 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -1332,9 +1332,9 @@ static void hp100_rxfill(struct net_device *dev)
>  		   ** Attempt to get a buffer and build a Rx PDL.
>  		 */
>  		ringptr = lp->rxrtail;
> -		if (0 == hp100_build_rx_pdl(ringptr, dev)) {
> +		if (0 == hp100_build_rx_pdl(ringptr, dev))
>  			return;	/* None available, return */
> -		}
> +

There is no need to add a blank line here.  Indeed there is a blank line
already, so I would have thought that checkpatch would have complained.
Do you run checkpatch on your patches?

julia

>
>  		/* Hand this PDL over to the card */
>  		/* Note: This needs performance page selected! */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322012624.GA5040%40siyah2.
>