* [PATCH] Remove space after * in pointer declarations
@ 2020-03-22 14:34 Soumyajit Deb
2020-03-23 10:39 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Soumyajit Deb @ 2020-03-22 14:34 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, perex
Remove space after * in pointer declaration to improve code readability
and to adhere to the standard coding style.
Reported by checkpatch.pl
Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
---
drivers/staging/hp/hp100.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 00b3db8144c3..2cf1104cd2dd 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -246,11 +246,11 @@ static void hp100_BM_shutdown(struct net_device *dev);
static void hp100_mmuinit(struct net_device *dev);
static void hp100_init_pdls(struct net_device *dev);
static int hp100_init_rxpdl(struct net_device *dev,
- register hp100_ring_t * ringptr,
- register u_int * pdlptr);
+ register hp100_ring_t *ringptr,
+ register u_int *pdlptr);
static int hp100_init_txpdl(struct net_device *dev,
- register hp100_ring_t * ringptr,
- register u_int * pdlptr);
+ register hp100_ring_t *ringptr,
+ register u_int *pdlptr);
static void hp100_rxfill(struct net_device *dev);
static void hp100_hwinit(struct net_device *dev);
static void hp100_clean_txring(struct net_device *dev);
@@ -264,7 +264,7 @@ static void hp100_RegisterDump(struct net_device *dev);
* because it was properly DMA allocated via pci_alloc_consistent(),
* so we just need to "retrieve" the original mapping to bus/phys/dma
* address - Jean II */
-static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 * ptr)
+static inline dma_addr_t virt_to_whatever(struct net_device *dev, u32 *ptr)
{
struct hp100_private *lp = netdev_priv(dev);
return ((u_long) ptr) + lp->whatever_offset;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove space after * in pointer declarations
2020-03-22 14:34 [PATCH] Remove space after * in pointer declarations Soumyajit Deb
@ 2020-03-23 10:39 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-03-23 10:39 UTC (permalink / raw)
To: Soumyajit Deb; +Cc: outreachy-kernel, perex
On Sun, Mar 22, 2020 at 08:04:49PM +0530, Soumyajit Deb wrote:
> Remove space after * in pointer declaration to improve code readability
> and to adhere to the standard coding style.
> Reported by checkpatch.pl
>
> Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
There is no "staging" or driver name in the subject line here :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-23 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-22 14:34 [PATCH] Remove space after * in pointer declarations Soumyajit Deb
2020-03-23 10:39 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.