From: DEEPAK VARMA <mh12gx2825@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com,
kieran.bingham@ideasonboard.com, Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>
Subject: Re: [PATCH] staging: comedi: ni_pcimio: remove old unused code
Date: Mon, 23 Mar 2020 00:14:48 +0530 [thread overview]
Message-ID: <20200322184446.GA11965@deeUbuntu> (raw)
In-Reply-To: <20200322070401.GA64528@kroah.com>
On Sun, Mar 22, 2020 at 08:04:01AM +0100, Greg KH wrote:
> On Sun, Mar 22, 2020 at 11:10:39AM +0530, Deepak R Varma wrote:
> > Found multiple #if 0 code blocks that appear to have never been used.
> > Additinal comments around intended functionality may be introduced
> > separately. As these commented code blocks do not appear to be
> > ever useful, they can be removed.
> >
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> >
> > ---
> > Resending patch for review. No changes since last version.
>
> Last time I thought I said to leave these as-is as they document devices
> that people might have and would be able to add to the driver easily.
>
> So I'm not going to take this patch this time either, sorry.
That comment was for a different patch for dt2801 driver patch. I will
discard this one too. No problem.
Thank you for your time.
Deepak.
>
> greg k-h
next prev parent reply other threads:[~2020-03-22 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 5:40 [PATCH] staging: comedi: ni_pcimio: remove old unused code Deepak R Varma
2020-03-22 7:04 ` Greg KH
2020-03-22 18:44 ` DEEPAK VARMA [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-10 22:44 Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322184446.GA11965@deeUbuntu \
--to=mh12gx2825@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.