* [PATCH] staging: comedi: ni_pcimio: remove old unused code
@ 2020-03-22 5:40 Deepak R Varma
2020-03-22 7:04 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Deepak R Varma @ 2020-03-22 5:40 UTC (permalink / raw)
To: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham
Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman
Found multiple #if 0 code blocks that appear to have never been used.
Additinal comments around intended functionality may be introduced
separately. As these commented code blocks do not appear to be
ever useful, they can be removed.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
Resending patch for review. No changes since last version.
drivers/staging/comedi/drivers/ni_pcimio.c | 48 ----------------------
1 file changed, 48 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c b/drivers/staging/comedi/drivers/ni_pcimio.c
index 7c82d5f9778f..d8e34d2e1104 100644
--- a/drivers/staging/comedi/drivers/ni_pcimio.c
+++ b/drivers/staging/comedi/drivers/ni_pcimio.c
@@ -481,43 +481,6 @@ static const struct ni_board_struct ni_boards[] = {
.ao_speed = 250,
.caldac = { ad8804, ad8804 },
},
-#if 0
- /* The 6115 boards probably need their own driver */
- [BOARD_PCI6115] = { /* .device_id = 0x2ed0, */
- .name = "pci-6115",
- .n_adchan = 4,
- .ai_maxdata = 0x0fff,
- .ai_fifo_depth = 8192,
- .gainlkup = ai_gain_611x,
- .ai_speed = 100,
- .n_aochan = 2,
- .ao_maxdata = 0xffff,
- .ao_671x = 1,
- .ao_fifo_depth = 2048,
- .ao_speed = 250,
- .reg_611x = 1,
- /* XXX */
- .caldac = { ad8804_debug, ad8804_debug, ad8804_debug },
- },
-#endif
-#if 0
- [BOARD_PXI6115] = { /* .device_id = ????, */
- .name = "pxi-6115",
- .n_adchan = 4,
- .ai_maxdata = 0x0fff,
- .ai_fifo_depth = 8192,
- .gainlkup = ai_gain_611x,
- .ai_speed = 100,
- .n_aochan = 2,
- .ao_maxdata = 0xffff,
- .ao_671x = 1,
- .ao_fifo_depth = 2048,
- .ao_speed = 250,
- .reg_611x = 1,
- /* XXX */
- .caldac = { ad8804_debug, ad8804_debug, ad8804_debug },
- },
-#endif
[BOARD_PCI6711] = {
.name = "pci-6711",
.n_aochan = 4,
@@ -569,17 +532,6 @@ static const struct ni_board_struct ni_boards[] = {
.reg_type = ni_reg_6711,
.caldac = { ad8804_debug },
},
-#if 0
- [BOARD_PXI6731] = { /* .device_id = ????, */
- .name = "pxi-6731",
- .n_aochan = 4,
- .ao_maxdata = 0xffff,
- .ao_fifo_depth = 8192,
- .ao_range_table = &range_bipolar10,
- .reg_type = ni_reg_6711,
- .caldac = { ad8804_debug },
- },
-#endif
[BOARD_PCI6733] = {
.name = "pci-6733",
.n_aochan = 8,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: comedi: ni_pcimio: remove old unused code
2020-03-22 5:40 [PATCH] staging: comedi: ni_pcimio: remove old unused code Deepak R Varma
@ 2020-03-22 7:04 ` Greg KH
2020-03-22 18:44 ` DEEPAK VARMA
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2020-03-22 7:04 UTC (permalink / raw)
To: Deepak R Varma
Cc: outreachy-kernel, daniel.baluta, kieran.bingham, Ian Abbott,
H Hartley Sweeten
On Sun, Mar 22, 2020 at 11:10:39AM +0530, Deepak R Varma wrote:
> Found multiple #if 0 code blocks that appear to have never been used.
> Additinal comments around intended functionality may be introduced
> separately. As these commented code blocks do not appear to be
> ever useful, they can be removed.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
>
> ---
> Resending patch for review. No changes since last version.
Last time I thought I said to leave these as-is as they document devices
that people might have and would be able to add to the driver easily.
So I'm not going to take this patch this time either, sorry.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: comedi: ni_pcimio: remove old unused code
2020-03-22 7:04 ` Greg KH
@ 2020-03-22 18:44 ` DEEPAK VARMA
0 siblings, 0 replies; 4+ messages in thread
From: DEEPAK VARMA @ 2020-03-22 18:44 UTC (permalink / raw)
To: Greg KH
Cc: outreachy-kernel, daniel.baluta, kieran.bingham, Ian Abbott,
H Hartley Sweeten
On Sun, Mar 22, 2020 at 08:04:01AM +0100, Greg KH wrote:
> On Sun, Mar 22, 2020 at 11:10:39AM +0530, Deepak R Varma wrote:
> > Found multiple #if 0 code blocks that appear to have never been used.
> > Additinal comments around intended functionality may be introduced
> > separately. As these commented code blocks do not appear to be
> > ever useful, they can be removed.
> >
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> >
> > ---
> > Resending patch for review. No changes since last version.
>
> Last time I thought I said to leave these as-is as they document devices
> that people might have and would be able to add to the driver easily.
>
> So I'm not going to take this patch this time either, sorry.
That comment was for a different patch for dt2801 driver patch. I will
discard this one too. No problem.
Thank you for your time.
Deepak.
>
> greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: comedi: ni_pcimio: remove old unused code
@ 2020-03-10 22:44 Deepak R Varma
0 siblings, 0 replies; 4+ messages in thread
From: Deepak R Varma @ 2020-03-10 22:44 UTC (permalink / raw)
To: outreachy-kernel
Found multiple #if 0 code blocks that appear to have never been used.
Additinal comments around intended functionality may be introduced
separately. As these commented code blocks do not appear to be
ever useful, they can be removed.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
drivers/staging/comedi/drivers/ni_pcimio.c | 48 ----------------------
1 file changed, 48 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c b/drivers/staging/comedi/drivers/ni_pcimio.c
index 7c82d5f9778f..d8e34d2e1104 100644
--- a/drivers/staging/comedi/drivers/ni_pcimio.c
+++ b/drivers/staging/comedi/drivers/ni_pcimio.c
@@ -481,43 +481,6 @@ static const struct ni_board_struct ni_boards[] = {
.ao_speed = 250,
.caldac = { ad8804, ad8804 },
},
-#if 0
- /* The 6115 boards probably need their own driver */
- [BOARD_PCI6115] = { /* .device_id = 0x2ed0, */
- .name = "pci-6115",
- .n_adchan = 4,
- .ai_maxdata = 0x0fff,
- .ai_fifo_depth = 8192,
- .gainlkup = ai_gain_611x,
- .ai_speed = 100,
- .n_aochan = 2,
- .ao_maxdata = 0xffff,
- .ao_671x = 1,
- .ao_fifo_depth = 2048,
- .ao_speed = 250,
- .reg_611x = 1,
- /* XXX */
- .caldac = { ad8804_debug, ad8804_debug, ad8804_debug },
- },
-#endif
-#if 0
- [BOARD_PXI6115] = { /* .device_id = ????, */
- .name = "pxi-6115",
- .n_adchan = 4,
- .ai_maxdata = 0x0fff,
- .ai_fifo_depth = 8192,
- .gainlkup = ai_gain_611x,
- .ai_speed = 100,
- .n_aochan = 2,
- .ao_maxdata = 0xffff,
- .ao_671x = 1,
- .ao_fifo_depth = 2048,
- .ao_speed = 250,
- .reg_611x = 1,
- /* XXX */
- .caldac = { ad8804_debug, ad8804_debug, ad8804_debug },
- },
-#endif
[BOARD_PCI6711] = {
.name = "pci-6711",
.n_aochan = 4,
@@ -569,17 +532,6 @@ static const struct ni_board_struct ni_boards[] = {
.reg_type = ni_reg_6711,
.caldac = { ad8804_debug },
},
-#if 0
- [BOARD_PXI6731] = { /* .device_id = ????, */
- .name = "pxi-6731",
- .n_aochan = 4,
- .ao_maxdata = 0xffff,
- .ao_fifo_depth = 8192,
- .ao_range_table = &range_bipolar10,
- .reg_type = ni_reg_6711,
- .caldac = { ad8804_debug },
- },
-#endif
[BOARD_PCI6733] = {
.name = "pci-6733",
.n_aochan = 8,
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-22 18:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-22 5:40 [PATCH] staging: comedi: ni_pcimio: remove old unused code Deepak R Varma
2020-03-22 7:04 ` Greg KH
2020-03-22 18:44 ` DEEPAK VARMA
-- strict thread matches above, loose matches on Subject: below --
2020-03-10 22:44 Deepak R Varma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.