* [PATCH v2] staging: hp100: Remove unnecessary braces
@ 2020-03-22 23:51 Gokce Kuler
2020-03-23 10:34 ` Greg KH
2020-03-23 11:09 ` [Outreachy kernel] " Julia Lawall
0 siblings, 2 replies; 3+ messages in thread
From: Gokce Kuler @ 2020-03-22 23:51 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Delete unnecessary blank line.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/hp/hp100.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 43607fb..32a9e29 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -2792,8 +2792,7 @@ void hp100_RegisterDump(struct net_device *dev)
/* Display Register contents except data port */
if (((Register != 0x10) && (Register != 0x12)) || (Page > 0))
printk("0x%.2x = 0x%.4x\n", Register, inw(ioaddr + Register));
-
- }
+ }
}
hp100_page(PERFORMANCE);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: hp100: Remove unnecessary braces
2020-03-22 23:51 [PATCH v2] staging: hp100: Remove unnecessary braces Gokce Kuler
@ 2020-03-23 10:34 ` Greg KH
2020-03-23 11:09 ` [Outreachy kernel] " Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-23 10:34 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Mon, Mar 23, 2020 at 02:51:03AM +0300, Gokce Kuler wrote:
> Delete unnecessary blank line.
This does not match your subject line :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: hp100: Remove unnecessary braces
2020-03-22 23:51 [PATCH v2] staging: hp100: Remove unnecessary braces Gokce Kuler
2020-03-23 10:34 ` Greg KH
@ 2020-03-23 11:09 ` Julia Lawall
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2020-03-23 11:09 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Mon, 23 Mar 2020, Gokce Kuler wrote:
> Delete unnecessary blank line.
The subject line and the commit log don't match. No braces are removed,
but one brace is moved to the right. It's not clear why.
julia
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index 43607fb..32a9e29 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -2792,8 +2792,7 @@ void hp100_RegisterDump(struct net_device *dev)
> /* Display Register contents except data port */
> if (((Register != 0x10) && (Register != 0x12)) || (Page > 0))
> printk("0x%.2x = 0x%.4x\n", Register, inw(ioaddr + Register));
> -
> - }
> + }
> }
> hp100_page(PERFORMANCE);
> }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200322235103.GA14205%40siyah2.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-22 23:51 [PATCH v2] staging: hp100: Remove unnecessary braces Gokce Kuler
2020-03-23 10:34 ` Greg KH
2020-03-23 11:09 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.