* [PATCH v2] staging: hp100: line over 80 characters
@ 2020-03-23 0:24 Gokce Kuler
2020-03-23 10:35 ` Greg KH
2020-03-23 11:07 ` [Outreachy kernel] " Julia Lawall
0 siblings, 2 replies; 4+ messages in thread
From: Gokce Kuler @ 2020-03-23 0:24 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Add a spaces character before that for correct syntax.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/hp/hp100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 32a9e29..280b5a0 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -550,7 +550,7 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
local_mode = 3;
} else if (chip == HP100_CHIPID_LASSEN &&
(lsw & (HP100_BM_WRITE | HP100_BM_READ)) ==
- (HP100_BM_WRITE | HP100_BM_READ)) {
+ (HP100_BM_WRITE | HP100_BM_READ)) {
/* Conversion to new PCI API :
* I don't have the doc, but I assume that the card
* can map the full 32bit address space.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] staging: hp100: line over 80 characters
2020-03-23 0:24 [PATCH v2] staging: hp100: line over 80 characters Gokce Kuler
@ 2020-03-23 10:35 ` Greg KH
2020-03-23 11:07 ` [Outreachy kernel] " Julia Lawall
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-03-23 10:35 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Mon, Mar 23, 2020 at 03:24:50AM +0300, Gokce Kuler wrote:
> Add a spaces character before that for correct syntax.
Does not match the subject line :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: hp100: line over 80 characters
2020-03-23 0:24 [PATCH v2] staging: hp100: line over 80 characters Gokce Kuler
2020-03-23 10:35 ` Greg KH
@ 2020-03-23 11:07 ` Julia Lawall
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-23 11:07 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Mon, 23 Mar 2020, Gokce Kuler wrote:
> Add a spaces character before that for correct syntax.
I think Greg already noted that the subject line doesn't match the log
message or what is done. Also, adding spaces won't affect the correctness
of the syntax. It can make the code more readable.
julia
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/hp/hp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
> index 32a9e29..280b5a0 100644
> --- a/drivers/staging/hp/hp100.c
> +++ b/drivers/staging/hp/hp100.c
> @@ -550,7 +550,7 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
> local_mode = 3;
> } else if (chip == HP100_CHIPID_LASSEN &&
> (lsw & (HP100_BM_WRITE | HP100_BM_READ)) ==
> - (HP100_BM_WRITE | HP100_BM_READ)) {
> + (HP100_BM_WRITE | HP100_BM_READ)) {
> /* Conversion to new PCI API :
> * I don't have the doc, but I assume that the card
> * can map the full 32bit address space.
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200323002450.GA15867%40siyah2.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: hp100: line over 80 characters
@ 2020-03-22 22:08 Gokce Kuler
0 siblings, 0 replies; 4+ messages in thread
From: Gokce Kuler @ 2020-03-22 22:08 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Moved to the bottom line after && operator for it exceeds 80 characters.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/hp/hp100.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index 1b957aa..43607fb 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -549,7 +549,8 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
#endif
local_mode = 3;
} else if (chip == HP100_CHIPID_LASSEN &&
- (lsw & (HP100_BM_WRITE | HP100_BM_READ)) == (HP100_BM_WRITE | HP100_BM_READ)) {
+ (lsw & (HP100_BM_WRITE | HP100_BM_READ)) ==
+ (HP100_BM_WRITE | HP100_BM_READ)) {
/* Conversion to new PCI API :
* I don't have the doc, but I assume that the card
* can map the full 32bit address space.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-23 11:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-23 0:24 [PATCH v2] staging: hp100: line over 80 characters Gokce Kuler
2020-03-23 10:35 ` Greg KH
2020-03-23 11:07 ` [Outreachy kernel] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2020-03-22 22:08 Gokce Kuler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.