From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: use kmem_cache pool during inline xattr lookups
Date: Sun, 22 Mar 2020 21:16:19 -0700 [thread overview]
Message-ID: <20200323041619.GD147648@google.com> (raw)
In-Reply-To: <08d03473-9871-ba10-4626-58c4479ef9d1@huawei.com>
On 03/19, Chao Yu wrote:
> Hi Ju Hyung,
>
> On 2020/3/18 20:14, Ju Hyung Park wrote:
> > Hi Chao.
> >
> > I got the time around to test this patch.
> > The v2 patch seems to work just fine, and the code looks good.
>
> Thanks a lot for the review and test.
>
> >
> > On Tue, Feb 25, 2020 at 7:17 PM Chao Yu <yuchao0@huawei.com> wrote:
> >> diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
> >> index a3360a97e624..e46a10eb0e42 100644
> >> --- a/fs/f2fs/xattr.c
> >> +++ b/fs/f2fs/xattr.c
> >> @@ -23,6 +23,25 @@
> >> #include "xattr.h"
> >> #include "segment.h"
> >>
> >> +static void *xattr_alloc(struct f2fs_sb_info *sbi, int size, bool *is_inline)
> >> +{
> >> + *is_inline = (size == sbi->inline_xattr_slab_size);
> >
> > Would it be meaningless to change this to the following code?
> > if (likely(size == sbi->inline_xattr_slab_size))
> > *is_inline = true;
> > else
> > *is_inline = false;
>
> Yup, I guess it's very rare that user will change inline xattr size via remount,
> so I'm okay with this change.
Applied like this. Thanks,
26 static void *xattr_alloc(struct f2fs_sb_info *sbi, int size, bool *is_inline)
27 {
28 if (likely(size == sbi->inline_xattr_slab_size)) {
29 *is_inline = true;
30 return kmem_cache_zalloc(sbi->inline_xattr_slab, GFP_NOFS);
31 }
32 *is_inline = false;
33 return f2fs_kzalloc(sbi, size, GFP_NOFS);
34 }
>
> Jaegeuk,
>
> Could you please help to update the patch in your git tree directly?
>
> Thanks,
>
> >
> > The above statement seems to be only false during the initial mount
> > and the rest(millions) seems to be always true.
> >
> > Thanks.
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Ju Hyung Park <qkrwngud825@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: Re: [PATCH v2] f2fs: use kmem_cache pool during inline xattr lookups
Date: Sun, 22 Mar 2020 21:16:19 -0700 [thread overview]
Message-ID: <20200323041619.GD147648@google.com> (raw)
In-Reply-To: <08d03473-9871-ba10-4626-58c4479ef9d1@huawei.com>
On 03/19, Chao Yu wrote:
> Hi Ju Hyung,
>
> On 2020/3/18 20:14, Ju Hyung Park wrote:
> > Hi Chao.
> >
> > I got the time around to test this patch.
> > The v2 patch seems to work just fine, and the code looks good.
>
> Thanks a lot for the review and test.
>
> >
> > On Tue, Feb 25, 2020 at 7:17 PM Chao Yu <yuchao0@huawei.com> wrote:
> >> diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c
> >> index a3360a97e624..e46a10eb0e42 100644
> >> --- a/fs/f2fs/xattr.c
> >> +++ b/fs/f2fs/xattr.c
> >> @@ -23,6 +23,25 @@
> >> #include "xattr.h"
> >> #include "segment.h"
> >>
> >> +static void *xattr_alloc(struct f2fs_sb_info *sbi, int size, bool *is_inline)
> >> +{
> >> + *is_inline = (size == sbi->inline_xattr_slab_size);
> >
> > Would it be meaningless to change this to the following code?
> > if (likely(size == sbi->inline_xattr_slab_size))
> > *is_inline = true;
> > else
> > *is_inline = false;
>
> Yup, I guess it's very rare that user will change inline xattr size via remount,
> so I'm okay with this change.
Applied like this. Thanks,
26 static void *xattr_alloc(struct f2fs_sb_info *sbi, int size, bool *is_inline)
27 {
28 if (likely(size == sbi->inline_xattr_slab_size)) {
29 *is_inline = true;
30 return kmem_cache_zalloc(sbi->inline_xattr_slab, GFP_NOFS);
31 }
32 *is_inline = false;
33 return f2fs_kzalloc(sbi, size, GFP_NOFS);
34 }
>
> Jaegeuk,
>
> Could you please help to update the patch in your git tree directly?
>
> Thanks,
>
> >
> > The above statement seems to be only false during the initial mount
> > and the rest(millions) seems to be always true.
> >
> > Thanks.
> > .
> >
next prev parent reply other threads:[~2020-03-23 4:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:17 [f2fs-dev] [PATCH v2] f2fs: use kmem_cache pool during inline xattr lookups Chao Yu
2020-02-25 10:17 ` Chao Yu
2020-03-18 12:14 ` [f2fs-dev] " Ju Hyung Park
2020-03-18 12:14 ` Ju Hyung Park
2020-03-19 2:37 ` [f2fs-dev] " Chao Yu
2020-03-19 2:37 ` Chao Yu
2020-03-23 4:16 ` Jaegeuk Kim [this message]
2020-03-23 4:16 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323041619.GD147648@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.