All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gokce Kuler <gokcekuler@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: quoted string split across lines
Date: Mon, 23 Mar 2020 13:09:22 +0100	[thread overview]
Message-ID: <20200323120922.GA780534@kroah.com> (raw)
In-Reply-To: <20200320233056.GA9027@siyah2>

On Sat, Mar 21, 2020 at 02:30:56AM +0300, Gokce Kuler wrote:
> quoted string merge to upper line
> 
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index e619d75a..47f7784 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
>  		tx_desc = &chan->tx_ring[i];
>  		rx_desc = &chan->rx_ring[i];
>  
> -		dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
> -				"tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> +		dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n",
>  				i, tx_desc->addr0, tx_desc->flags,
>  				tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
>  	}
> -- 
> 2.7.4

You sent 2 patches with the same exact subject line, yet they did
different things, which isn't ok. :(

Please fix up both and resend.

thanks,

greg k-h


      parent reply	other threads:[~2020-03-23 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 23:30 [PATCH] staging: mt7621-dma: quoted string split across lines Gokce Kuler
2020-03-21  7:24 ` [Outreachy kernel] " Julia Lawall
2020-03-23 12:09 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323120922.GA780534@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gokcekuler@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.