* [PATCH] staging: mt7621-dma: quoted string split across lines
@ 2020-03-20 23:30 Gokce Kuler
2020-03-21 7:24 ` [Outreachy kernel] " Julia Lawall
2020-03-23 12:09 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Gokce Kuler @ 2020-03-20 23:30 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
quoted string merge to upper line
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index e619d75a..47f7784 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
tx_desc = &chan->tx_ring[i];
rx_desc = &chan->rx_ring[i];
- dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
- "tx addr1: %08x, rx addr0 %08x, flags %08x\n",
+ dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n",
i, tx_desc->addr0, tx_desc->flags,
tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: quoted string split across lines
2020-03-20 23:30 [PATCH] staging: mt7621-dma: quoted string split across lines Gokce Kuler
@ 2020-03-21 7:24 ` Julia Lawall
2020-03-23 12:09 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2020-03-21 7:24 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
You seem to have three patches with the same subject line. Perhaps you
could merge them into a single patch.
On Sat, 21 Mar 2020, Gokce Kuler wrote:
> quoted string merge to upper line
The verb should come first, so that would be Merge.
Upper line doesn't seem very useful.
Maybe it could be:
Concatenate a string that appeared on two lines, in order to make the
atring easier to find if the message is printed.
julia
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index e619d75a..47f7784 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
> tx_desc = &chan->tx_ring[i];
> rx_desc = &chan->rx_ring[i];
>
> - dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
> - "tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> + dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> i, tx_desc->addr0, tx_desc->flags,
> tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
> }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200320233056.GA9027%40siyah2.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: quoted string split across lines
2020-03-20 23:30 [PATCH] staging: mt7621-dma: quoted string split across lines Gokce Kuler
2020-03-21 7:24 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-23 12:09 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2020-03-23 12:09 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel
On Sat, Mar 21, 2020 at 02:30:56AM +0300, Gokce Kuler wrote:
> quoted string merge to upper line
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index e619d75a..47f7784 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
> tx_desc = &chan->tx_ring[i];
> rx_desc = &chan->rx_ring[i];
>
> - dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
> - "tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> + dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> i, tx_desc->addr0, tx_desc->flags,
> tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
> }
> --
> 2.7.4
You sent 2 patches with the same exact subject line, yet they did
different things, which isn't ok. :(
Please fix up both and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-20 23:30 [PATCH] staging: mt7621-dma: quoted string split across lines Gokce Kuler
2020-03-21 7:24 ` [Outreachy kernel] " Julia Lawall
2020-03-23 12:09 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.