From: Andrew Lunn <andrew@lunn.ch>
To: David Bauer <mail@david-bauer.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: at803x: select correct page on initialization
Date: Mon, 23 Mar 2020 17:53:45 +0100 [thread overview]
Message-ID: <20200323165345.GE32387@lunn.ch> (raw)
In-Reply-To: <20200323162730.88236-1-mail@david-bauer.net>
On Mon, Mar 23, 2020 at 05:27:30PM +0100, David Bauer wrote:
> The Atheros AR8031 and AR8033 expose different registers for SGMII/Fiber
> as well as the copper side of the PHY depending on the BT_BX_REG_SEL bit
> in the chip configure register.
>
> The driver assumes the copper side is selected on probe, but this might
> not be the case depending which page was last selected by the
> bootloader.
>
> Select the copper page when initializing the configuration to circumvent
> this.
Hi David
You might want to look at phy_read_paged(), phy_write_paged(), etc,
depending on your needs. There can be locking issues, which these
functions address.
Andrew
next prev parent reply other threads:[~2020-03-23 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 16:27 [PATCH] net: phy: at803x: select correct page on initialization David Bauer
2020-03-23 16:53 ` Andrew Lunn [this message]
2020-03-23 21:08 ` David Bauer
2020-03-23 21:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323165345.GE32387@lunn.ch \
--to=andrew@lunn.ch \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.