From: Andrew Lunn <andrew@lunn.ch>
To: David Bauer <mail@david-bauer.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: at803x: select correct page on initialization
Date: Mon, 23 Mar 2020 22:11:50 +0100 [thread overview]
Message-ID: <20200323211150.GA12621@lunn.ch> (raw)
In-Reply-To: <f5f5c674-8563-bd92-c065-0bfbcc364ef5@david-bauer.net>
On Mon, Mar 23, 2020 at 10:08:49PM +0100, David Bauer wrote:
> Hello Andrew,
>
> On 3/23/20 5:53 PM, Andrew Lunn wrote:
> > You might want to look at phy_read_paged(), phy_write_paged(), etc,
> > depending on your needs. There can be locking issues, which these
> > functions address.
>
> Thanks for the hint, i was not aware of these methods. I see how they can handle
> e.g. the page-switching logic in phy_read_paged.
>
> However i still need to select the copper page on config initialization manually,
> as genphy_update_link is not page aware or am i missing something here?
Hi David
Yes, for that initial setup, you need to directly write to the
register. But at803x_aneg_done() should use these helpers.
Andrew
prev parent reply other threads:[~2020-03-23 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 16:27 [PATCH] net: phy: at803x: select correct page on initialization David Bauer
2020-03-23 16:53 ` Andrew Lunn
2020-03-23 21:08 ` David Bauer
2020-03-23 21:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323211150.GA12621@lunn.ch \
--to=andrew@lunn.ch \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.