From: Rob Herring <robh@kernel.org>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] drm/panel: Add Starry KR070PE2T
Date: Mon, 23 Mar 2020 15:27:11 -0600 [thread overview]
Message-ID: <20200323212711.GA6856@bogus> (raw)
In-Reply-To: <280a128711458950b55b070dbf6f07a1@pascalroeleven.nl>
On Wed, Mar 11, 2020 at 11:23:27AM +0100, Pascal Roeleven wrote:
> On 2020-03-10 19:54, Sam Ravnborg wrote:
> > A few things to improve.
> >
> > The binding should be a separate patch.
> > subject - shall start with dt-bindings:
> > Shall be sent to deveicetree mailing list.
>
> Hi Sam,
>
> Thank you very much for your review.
> I did consider this. The reason I combined the patches, is that the binding
> depends on the display so I thought they were related in some way. Didn't
> know the correct procedure to handle this. I will split them apart in v2.
FYI, checkpatch.pl will tell you both bindings should be a separate
patch and that they should be in DT schema format.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/2] drm/panel: Add Starry KR070PE2T
Date: Mon, 23 Mar 2020 15:27:11 -0600 [thread overview]
Message-ID: <20200323212711.GA6856@bogus> (raw)
In-Reply-To: <280a128711458950b55b070dbf6f07a1@pascalroeleven.nl>
On Wed, Mar 11, 2020 at 11:23:27AM +0100, Pascal Roeleven wrote:
> On 2020-03-10 19:54, Sam Ravnborg wrote:
> > A few things to improve.
> >
> > The binding should be a separate patch.
> > subject - shall start with dt-bindings:
> > Shall be sent to deveicetree mailing list.
>
> Hi Sam,
>
> Thank you very much for your review.
> I did consider this. The reason I combined the patches, is that the binding
> depends on the display so I thought they were related in some way. Didn't
> know the correct procedure to handle this. I will split them apart in v2.
FYI, checkpatch.pl will tell you both bindings should be a separate
patch and that they should be in DT schema format.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Pascal Roeleven <dev@pascalroeleven.nl>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, Sam Ravnborg <sam@ravnborg.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] drm/panel: Add Starry KR070PE2T
Date: Mon, 23 Mar 2020 15:27:11 -0600 [thread overview]
Message-ID: <20200323212711.GA6856@bogus> (raw)
In-Reply-To: <280a128711458950b55b070dbf6f07a1@pascalroeleven.nl>
On Wed, Mar 11, 2020 at 11:23:27AM +0100, Pascal Roeleven wrote:
> On 2020-03-10 19:54, Sam Ravnborg wrote:
> > A few things to improve.
> >
> > The binding should be a separate patch.
> > subject - shall start with dt-bindings:
> > Shall be sent to deveicetree mailing list.
>
> Hi Sam,
>
> Thank you very much for your review.
> I did consider this. The reason I combined the patches, is that the binding
> depends on the display so I thought they were related in some way. Didn't
> know the correct procedure to handle this. I will split them apart in v2.
FYI, checkpatch.pl will tell you both bindings should be a separate
patch and that they should be in DT schema format.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-23 21:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 10:27 [PATCH 0/2] Add support for Topwise A721 tablet Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 10:27 ` [PATCH 1/2] drm/panel: Add Starry KR070PE2T Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 18:54 ` Sam Ravnborg
2020-03-10 18:54 ` Sam Ravnborg
2020-03-10 18:54 ` Sam Ravnborg
2020-03-10 19:10 ` Ville Syrjälä
2020-03-10 19:10 ` Ville Syrjälä
2020-03-10 19:10 ` Ville Syrjälä
2020-03-11 10:23 ` Pascal Roeleven
2020-03-11 10:23 ` Pascal Roeleven
2020-03-11 10:23 ` Pascal Roeleven
2020-03-23 21:27 ` Rob Herring [this message]
2020-03-23 21:27 ` Rob Herring
2020-03-23 21:27 ` Rob Herring
2020-03-10 10:27 ` [PATCH 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 10:27 ` Pascal Roeleven
2020-03-10 14:02 ` [linux-sunxi] " Ondřej Jirman
2020-03-10 14:02 ` Ondřej Jirman
2020-03-10 14:02 ` Ondřej Jirman
2020-03-11 10:10 ` Pascal Roeleven
2020-03-11 10:10 ` Pascal Roeleven
2020-03-11 10:10 ` Pascal Roeleven
2020-03-10 14:04 ` Ondřej Jirman
2020-03-10 14:04 ` Ondřej Jirman
2020-03-10 14:04 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323212711.GA6856@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dev@pascalroeleven.nl \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.