Re: [PATCH 1/3] Staging: speakup: Avoid multiple assignments.

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Hello,

Sam Muhammed, le lun. 23 mars 2020 17:38:43 -0400, a ecrit:
> Modify the code to avoid multiple assignments by just
> doing the assignment in two steps.

The original version of the code is considered easier to read.
Yes, the tools say multiple assignments should be avoided, but that's
not a strict rule :)

> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> ---
>  drivers/staging/speakup/main.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index 02471d932d71..6efa0b245bef 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -263,9 +263,12 @@ static unsigned char get_attributes(struct vc_data *vc, u16 *pos)
> 
>  static void speakup_date(struct vc_data *vc)
>  {
> -	spk_x = spk_cx = vc->vc_x;
> -	spk_y = spk_cy = vc->vc_y;
> -	spk_pos = spk_cp = vc->vc_pos;
> +	spk_cx = vc->vc_x;
> +	spk_x = spk_cx;
> +	spk_cy = vc->vc_y;
> +	spk_y = spk_cy;
> +	spk_cp = vc->vc_pos;
> +	spk_pos = spk_cp;
>  	spk_old_attr = spk_attr;
>  	spk_attr = get_attributes(vc, (u_short *)spk_pos);
>  }
> @@ -1672,9 +1675,12 @@ static int speak_highlight(struct vc_data *vc)
>  		spk_do_flush();
>  		spkup_write(speakup_console[vc_num]->ht.highbuf[hc],
>  			    speakup_console[vc_num]->ht.highsize[hc]);
> -		spk_pos = spk_cp = speakup_console[vc_num]->ht.rpos[hc];
> -		spk_x = spk_cx = speakup_console[vc_num]->ht.rx[hc];
> -		spk_y = spk_cy = speakup_console[vc_num]->ht.ry[hc];
> +		spk_cp = speakup_console[vc_num]->ht.rpos[hc];
> +		spk_pos = spk_cp;
> +		spk_cx = speakup_console[vc_num]->ht.rx[hc];
> +		spk_x = spk_cx;
> +		spk_cy = speakup_console[vc_num]->ht.ry[hc];
> +		spk_y = spk_cy;
>  		return 1;
>  	}
>  	return 0;
> ---
> 2.20.1
>