From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Sam Muhammed <jane.pnx9@gmail.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 3/3] Staging: speakup: Add identifier name to function declaration arguments.
Date: Mon, 23 Mar 2020 23:14:49 +0100 [thread overview]
Message-ID: <20200323221449.evmqf7kasqde3nqg@function> (raw)
In-Reply-To: <b2a1ca962553194840d8cd2bf1f7d3174e3b1336.1584997290.git.jane.pnx9@gmail.com>
Sam Muhammed, le lun. 23 mars 2020 17:38:45 -0400, a ecrit:
> The void (*read_buff_add) argument didn't have an identifier name,
> adding an identifier name to match coding style.
>
> Checkpatch.pl CHECK: function definition argument 'u_char'
> should also have an identifier name.
>
> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index a2fc72c29894..fc6a9416829c 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -189,7 +189,7 @@ struct spk_synth {
> void (*flush)(struct spk_synth *synth);
> int (*is_alive)(struct spk_synth *synth);
> int (*synth_adjust)(struct st_var_header *var);
> - void (*read_buff_add)(u_char);
> + void (*read_buff_add)(u_char c);
> unsigned char (*get_index)(struct spk_synth *synth);
> struct synth_indexing indexing;
> int alive;
> ---
> 2.20.1
>
prev parent reply other threads:[~2020-03-23 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 21:38 [PATCH 0/3] Staging: speakup: Misc cleanups and code reformatting Sam Muhammed
2020-03-23 21:38 ` [PATCH 1/3] Staging: speakup: Avoid multiple assignments Sam Muhammed
2020-03-23 22:13 ` Samuel Thibault
2020-03-23 23:13 ` [Outreachy kernel] " Sam Muhammed
2020-03-23 23:20 ` Samuel Thibault
2020-03-23 23:27 ` Sam Muhammed
2020-03-23 21:38 ` [PATCH 2/3] Staging: speakup: Use sizeof(*var) in kmalloc() Sam Muhammed
2020-03-23 22:14 ` Samuel Thibault
2020-03-23 21:38 ` [PATCH 3/3] Staging: speakup: Add identifier name to function declaration arguments Sam Muhammed
2020-03-23 22:14 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323221449.evmqf7kasqde3nqg@function \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=gregkh@linuxfoundation.org \
--cc=jane.pnx9@gmail.com \
--cc=kirk@reisers.ca \
--cc=outreachy-kernel@googlegroups.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.