From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Florian Weimer <fw@deneb.enyo.de>,
Andy Lutomirski <luto@kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] ext4: Give 32bit personalities 32bit hashes
Date: Tue, 24 Mar 2020 14:47:54 -0400 [thread overview]
Message-ID: <20200324184754.GG53396@mit.edu> (raw)
In-Reply-To: <CAFEAcA_6RY1XFVNJCo5=tTkv2GQpXZRqh_Zz4dYadq-8MJZgTQ@mail.gmail.com>
On Tue, Mar 24, 2020 at 09:29:58AM +0000, Peter Maydell wrote:
>
> On the contrary, that would be a much better interface for QEMU.
> We always know when we're doing an open-syscall on behalf
> of the guest, and it would be trivial to make the fcntl() call then.
> That would ensure that we don't accidentally get the
> '32-bit semantics' on file descriptors QEMU opens for its own
> purposes, and wouldn't leave us open to the risk in future that
> setting the PER_LINUX32 flag for all of QEMU causes
> unexpected extra behaviour in future kernels that would be correct
> for the guest binary but wrong/broken for QEMU's own internals.
If using a flag set by fcntl is better for qemu, then by all means
let's go with that instead of using a personality flag/number.
Linus, do you have what you need to do a respin of the patch?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
Linux API <linux-api@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
stable <stable@vger.kernel.org>,
Florian Weimer <fw@deneb.enyo.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andy Lutomirski <luto@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Give 32bit personalities 32bit hashes
Date: Tue, 24 Mar 2020 14:47:54 -0400 [thread overview]
Message-ID: <20200324184754.GG53396@mit.edu> (raw)
In-Reply-To: <CAFEAcA_6RY1XFVNJCo5=tTkv2GQpXZRqh_Zz4dYadq-8MJZgTQ@mail.gmail.com>
On Tue, Mar 24, 2020 at 09:29:58AM +0000, Peter Maydell wrote:
>
> On the contrary, that would be a much better interface for QEMU.
> We always know when we're doing an open-syscall on behalf
> of the guest, and it would be trivial to make the fcntl() call then.
> That would ensure that we don't accidentally get the
> '32-bit semantics' on file descriptors QEMU opens for its own
> purposes, and wouldn't leave us open to the risk in future that
> setting the PER_LINUX32 flag for all of QEMU causes
> unexpected extra behaviour in future kernels that would be correct
> for the guest binary but wrong/broken for QEMU's own internals.
If using a flag set by fcntl is better for qemu, then by all means
let's go with that instead of using a personality flag/number.
Linus, do you have what you need to do a respin of the patch?
- Ted
next prev parent reply other threads:[~2020-03-24 18:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 11:31 [PATCH] ext4: Give 32bit personalities 32bit hashes Linus Walleij
2020-03-17 11:31 ` Linus Walleij
2020-03-17 11:52 ` Florian Weimer
2020-03-17 11:52 ` Florian Weimer
2020-03-17 12:38 ` Linus Walleij
2020-03-17 12:38 ` Linus Walleij
2020-03-17 11:58 ` Peter Maydell
2020-03-17 11:58 ` Peter Maydell
2020-03-19 15:13 ` Linus Walleij
2020-03-19 15:13 ` Linus Walleij
2020-03-19 15:25 ` Peter Maydell
2020-03-19 15:25 ` Peter Maydell
2020-03-19 22:23 ` Linus Walleij
2020-03-19 22:23 ` Linus Walleij
2020-03-24 2:34 ` Theodore Y. Ts'o
2020-03-24 2:34 ` Theodore Y. Ts'o
2020-03-24 9:29 ` Peter Maydell
2020-03-24 9:29 ` Peter Maydell
2020-03-24 18:47 ` Theodore Y. Ts'o [this message]
2020-03-24 18:47 ` Theodore Y. Ts'o
2020-03-24 21:17 ` Linus Walleij
2020-03-24 21:17 ` Linus Walleij
2020-03-17 22:28 ` Andreas Dilger
2020-03-17 22:28 ` Andreas Dilger
2020-03-19 15:18 ` Linus Walleij
2020-03-19 15:18 ` Linus Walleij
2020-03-17 22:30 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324184754.GG53396@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=fw@deneb.enyo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.