[PATCH] staging: octeon-usb: line over 80 characters

[PATCH] staging: octeon-usb: line over 80 characters

[Gokce Kuler]

Moved from the comma character to the bottom line after
for it exceeds 80 characters.

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
index a73289ba..dbafd46 100644
--- a/drivers/staging/octeon-usb/octeon-hcd.c
+++ b/drivers/staging/octeon-usb/octeon-hcd.c
@@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
 						     hcintmsk.u32);
 				usbc_hcchar.s.chdis = 1;
 				cvmx_usb_write_csr32(usb,
-						     CVMX_USBCX_HCCHARX(channel, usb->index),
+						     CVMX_USBCX_HCCHARX(
+						     channel, usb->index),
 						     usbc_hcchar.u32);
 				return 0;
 			} else if (usbc_hcint.s.xfercompl) {
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: octeon-usb: line over 80 characters

[Julia Lawall]

On Wed, 25 Mar 2020, Gokce Kuler wrote:

> Moved from the comma character to the bottom line after
> for it exceeds 80 characters.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index a73289ba..dbafd46 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2641,7 +2641,8 @@ static int cvmx_usb_poll_channel(struct octeon_hcd *usb, int channel)
>  						     hcintmsk.u32);
>  				usbc_hcchar.s.chdis = 1;
>  				cvmx_usb_write_csr32(usb,
> -						     CVMX_USBCX_HCCHARX(channel, usb->index),
> +						     CVMX_USBCX_HCCHARX(
> +						     channel, usb->index),
>  						     usbc_hcchar.u32);

This is confusing,  It is had to see which arguments go with which
function.  I don't know if it would be acceptable to add a few spaces in
front of channel.

julia

>  				return 0;
>  			} else if (usbc_hcint.s.xfercompl) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325202714.GA14306%40siyah2.
>

Re: [Outreachy kernel] [PATCH] staging: octeon-usb: line over 80 characters

[Lakshmi Ramasubramanian]

On 3/25/20 1:38 PM, Julia Lawall wrote:

>>   				cvmx_usb_write_csr32(usb,
>> -						     CVMX_USBCX_HCCHARX(channel, usb->index),
>> +						     CVMX_USBCX_HCCHARX(
>> +						     channel, usb->index),
>>   						     usbc_hcchar.u32);
> 
> This is confusing,  It is had to see which arguments go with which
> function.  I don't know if it would be acceptable to add a few spaces in
> front of channel.

I agree with Julia. Can we do the following and still be within the 80 
character per line?

cvmx_usb_write_csr32(usb,
		     CVMX_USBCX_HCCHARX(channel,
                                         usb->index),
                      usbc_hcchar.u32);

thanks,
  -lakshmi