From: Bjorn Helgaas <helgaas@kernel.org>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Andrew Murray <andrew.murray@arm.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Roman Bacik <roman.bacik@broadcom.com>
Subject: Re: [PATCH 2/3] PCI: iproc: fix invalidating PAXB address mapping
Date: Thu, 26 Mar 2020 10:33:18 -0500 [thread overview]
Message-ID: <20200326153318.GA11697@google.com> (raw)
In-Reply-To: <1585206447-1363-3-git-send-email-srinath.mannam@broadcom.com>
On Thu, Mar 26, 2020 at 12:37:26PM +0530, Srinath Mannam wrote:
> From: Roman Bacik <roman.bacik@broadcom.com>
>
> Second stage bootloader prior to Linux boot may use all inbound windows
> including IARR1/IMAP1. We need to ensure all previous configuration of
> inbound windows are invalidated during the initialization stage of the
> Linux iProc PCIe driver. Add fix to invalidate IARR1/IMAP1 because it was
> missed in previous patch.
>
> Fixes: 9415743e4c8a ("PCI: iproc: Invalidate PAXB address mapping")
> Signed-off-by: Roman Bacik <roman.bacik@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index 6972ca4..e7f0d58 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -351,6 +351,8 @@ static const u16 iproc_pcie_reg_paxb_v2[IPROC_PCIE_MAX_NUM_REG] = {
> [IPROC_PCIE_OMAP3] = 0xdf8,
> [IPROC_PCIE_IARR0] = 0xd00,
> [IPROC_PCIE_IMAP0] = 0xc00,
> + [IPROC_PCIE_IARR1] = 0xd08,
> + [IPROC_PCIE_IMAP1] = 0xd70,
And paxb_v2_ib_map[] has a comment saying "IARR1/IMAP1 (currently
unused)". Is that comment now wrong?
> [IPROC_PCIE_IARR2] = 0xd10,
> [IPROC_PCIE_IMAP2] = 0xcc0,
> [IPROC_PCIE_IARR3] = 0xe00,
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Roman Bacik <roman.bacik@broadcom.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>,
Andrew Murray <andrew.murray@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] PCI: iproc: fix invalidating PAXB address mapping
Date: Thu, 26 Mar 2020 10:33:18 -0500 [thread overview]
Message-ID: <20200326153318.GA11697@google.com> (raw)
In-Reply-To: <1585206447-1363-3-git-send-email-srinath.mannam@broadcom.com>
On Thu, Mar 26, 2020 at 12:37:26PM +0530, Srinath Mannam wrote:
> From: Roman Bacik <roman.bacik@broadcom.com>
>
> Second stage bootloader prior to Linux boot may use all inbound windows
> including IARR1/IMAP1. We need to ensure all previous configuration of
> inbound windows are invalidated during the initialization stage of the
> Linux iProc PCIe driver. Add fix to invalidate IARR1/IMAP1 because it was
> missed in previous patch.
>
> Fixes: 9415743e4c8a ("PCI: iproc: Invalidate PAXB address mapping")
> Signed-off-by: Roman Bacik <roman.bacik@broadcom.com>
> ---
> drivers/pci/controller/pcie-iproc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index 6972ca4..e7f0d58 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -351,6 +351,8 @@ static const u16 iproc_pcie_reg_paxb_v2[IPROC_PCIE_MAX_NUM_REG] = {
> [IPROC_PCIE_OMAP3] = 0xdf8,
> [IPROC_PCIE_IARR0] = 0xd00,
> [IPROC_PCIE_IMAP0] = 0xc00,
> + [IPROC_PCIE_IARR1] = 0xd08,
> + [IPROC_PCIE_IMAP1] = 0xd70,
And paxb_v2_ib_map[] has a comment saying "IARR1/IMAP1 (currently
unused)". Is that comment now wrong?
> [IPROC_PCIE_IARR2] = 0xd10,
> [IPROC_PCIE_IMAP2] = 0xcc0,
> [IPROC_PCIE_IARR3] = 0xe00,
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-26 15:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:07 [PATCH 0/3] PCI: iproc: Add fixes to pcie iproc Srinath Mannam
2020-03-26 7:07 ` Srinath Mannam
2020-03-26 7:07 ` [PATCH 1/3] PCI: iproc: fix out of bound array access Srinath Mannam
2020-03-26 7:07 ` Srinath Mannam
2020-03-26 19:48 ` Bjorn Helgaas
2020-03-26 19:48 ` Bjorn Helgaas
2020-03-26 20:27 ` Ray Jui
2020-03-26 20:27 ` Ray Jui
2020-03-26 20:48 ` Bjorn Helgaas
2020-03-26 20:48 ` Bjorn Helgaas
2020-03-30 17:04 ` Ray Jui
2020-03-30 17:04 ` Ray Jui
2020-03-26 7:07 ` [PATCH 2/3] PCI: iproc: fix invalidating PAXB address mapping Srinath Mannam
2020-03-26 7:07 ` Srinath Mannam
2020-03-26 15:28 ` Bjorn Helgaas
2020-03-26 15:28 ` Bjorn Helgaas
2020-03-26 15:33 ` Bjorn Helgaas [this message]
2020-03-26 15:33 ` Bjorn Helgaas
2020-03-26 15:38 ` Roman Bacik
2020-03-26 15:38 ` Roman Bacik
2020-03-26 7:07 ` [PATCH 3/3] PCI: iproc: Display PCIe Link information Srinath Mannam
2020-03-26 7:07 ` Srinath Mannam
2020-03-26 15:12 ` Bjorn Helgaas
2020-03-26 15:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326153318.GA11697@google.com \
--to=helgaas@kernel.org \
--cc=andrew.murray@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=roman.bacik@broadcom.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.