All of lore.kernel.org
 help / color / mirror / Atom feed
From: gokcekuler@gmail.com
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, tkjos@android.com, maco@android.com,
	arve@android.com, joel@joelfernandes.org, christian@brauner.io
Subject: [PATCH] staging: android: struct should normally be const
Date: Fri, 27 Mar 2020 02:56:50 +0300	[thread overview]
Message-ID: <20200326235650.GA737@siyah2> (raw)

Add const before static struct file_operations for tells 
the compiler to not let anybody modify it. 

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/android/ashmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 8044510..395929d 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
 
 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	static struct file_operations vmfile_fops;
+	const static struct file_operations vmfile_fops;
 	struct ashmem_area *asma = file->private_data;
 	int ret = 0;
 
-- 
2.7.4



             reply	other threads:[~2020-03-26 23:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 23:56 gokcekuler [this message]
2020-03-27  8:56 ` [PATCH] staging: android: struct should normally be const Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200326235650.GA737@siyah2 \
    --to=gokcekuler@gmail.com \
    --cc=arve@android.com \
    --cc=christian@brauner.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=maco@android.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=tkjos@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.