[PATCH] staging: android: struct should normally be const

[PATCH] staging: android: struct should normally be const

[gokcekuler]

Add const before static struct file_operations for tells 
the compiler to not let anybody modify it. 

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/android/ashmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 8044510..395929d 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
 
 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
 {
-	static struct file_operations vmfile_fops;
+	const static struct file_operations vmfile_fops;
 	struct ashmem_area *asma = file->private_data;
 	int ret = 0;
 
-- 
2.7.4

Re: [PATCH] staging: android: struct should normally be const

[Greg KH]

Some comments on the patch, but first, please properly set the "From:"
text in your email client, it does not show your name :(

On Fri, Mar 27, 2020 at 02:56:50AM +0300, gokcekuler@gmail.com wrote:
> Add const before static struct file_operations for tells 
> the compiler to not let anybody modify it. 

You have trailing whitespace on your changelog text :(

But, most importantly, what are you trying to do in this patch?

Why would you make this const?  Who is telling you to do that?

> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 8044510..395929d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	const static struct file_operations vmfile_fops;

Did you test-build this patch?  It breaks the build horribly which is a
big hint that this is not a correct change :)

thanks,

greg k-h