From: Christoph Hellwig <hch@lst.de>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 4/5] block: simplify queue allocation
Date: Fri, 27 Mar 2020 12:21:31 +0100 [thread overview]
Message-ID: <20200327112131.GA1096@lst.de> (raw)
In-Reply-To: <SN4PR0401MB3598BF20E4DCF8F1B129625E9BCC0@SN4PR0401MB3598.namprd04.prod.outlook.com>
On Fri, Mar 27, 2020 at 10:11:08AM +0000, Johannes Thumshirn wrote:
> On 27/03/2020 09:34, Christoph Hellwig wrote:
> > -struct request_queue *blk_alloc_queue(gfp_t gfp_mask)
> > -{
> > - return blk_alloc_queue_node(gfp_mask, NUMA_NO_NODE);
> > -}
> > -EXPORT_SYMBOL(blk_alloc_queue);
>
> Why are you removing the non _node() variant? The memory allocation
> function for instance have this indirection as well and I don't think it
> simplifies a lot passing NUMA_NO_NODE in each block driver.
Because the two variants are rather pointless. And this might get
more people to actually pass a useful node ID instead of copy and
pasting some old example code.
next prev parent reply other threads:[~2020-03-27 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:30 simplify queue allocation Christoph Hellwig
2020-03-27 8:30 ` [PATCH 1/5] block: add a blk_mq_init_queue_data helper Christoph Hellwig
2020-03-27 10:05 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 2/5] null_blk: use blk_mq_init_queue_data Christoph Hellwig
2020-03-27 10:06 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 3/5] bcache: pass the make_request methods to blk_queue_make_request Christoph Hellwig
2020-03-30 11:15 ` Coly Li
2020-03-27 8:30 ` [PATCH 4/5] block: simplify queue allocation Christoph Hellwig
2020-03-27 10:11 ` Johannes Thumshirn
2020-03-27 11:21 ` Christoph Hellwig [this message]
2020-03-27 16:24 ` Johannes Thumshirn
2020-03-27 16:26 ` Jens Axboe
2020-03-27 8:30 ` [PATCH 5/5] Revert "blkdev: check for valid request queue before issuing flush" Christoph Hellwig
2020-03-27 15:53 ` simplify queue allocation Jens Axboe
2020-03-27 16:17 ` Christoph Hellwig
2020-03-27 16:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327112131.GA1096@lst.de \
--to=hch@lst.de \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.