From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: simplify queue allocation
Date: Fri, 27 Mar 2020 17:17:54 +0100 [thread overview]
Message-ID: <20200327161754.GA19480@lst.de> (raw)
In-Reply-To: <b1123d19-0c4a-5d3d-d0d4-0a412830c2b0@kernel.dk>
On Fri, Mar 27, 2020 at 09:53:16AM -0600, Jens Axboe wrote:
> On 3/27/20 2:30 AM, Christoph Hellwig wrote:
> > Hi Jens,
> >
> > this series ensures all allocated queues have a valid ->make_request_fn
> > and also nicely consolidates the code for allocating queues.
>
> This seems fine to me, but might be a good idea to shuffle 4/5 as the
> last one, and do that one inside the merge window to avoid any potential
> silly merge conflicts.
they should be trivial to reorder if you want to skip patch 4 for now.
But looking at current linux-next there isn't any conflict yet,
and I don't expect one as most block drivers go through the block
tree anyway.
next prev parent reply other threads:[~2020-03-27 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:30 simplify queue allocation Christoph Hellwig
2020-03-27 8:30 ` [PATCH 1/5] block: add a blk_mq_init_queue_data helper Christoph Hellwig
2020-03-27 10:05 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 2/5] null_blk: use blk_mq_init_queue_data Christoph Hellwig
2020-03-27 10:06 ` Johannes Thumshirn
2020-03-27 8:30 ` [PATCH 3/5] bcache: pass the make_request methods to blk_queue_make_request Christoph Hellwig
2020-03-30 11:15 ` Coly Li
2020-03-27 8:30 ` [PATCH 4/5] block: simplify queue allocation Christoph Hellwig
2020-03-27 10:11 ` Johannes Thumshirn
2020-03-27 11:21 ` Christoph Hellwig
2020-03-27 16:24 ` Johannes Thumshirn
2020-03-27 16:26 ` Jens Axboe
2020-03-27 8:30 ` [PATCH 5/5] Revert "blkdev: check for valid request queue before issuing flush" Christoph Hellwig
2020-03-27 15:53 ` simplify queue allocation Jens Axboe
2020-03-27 16:17 ` Christoph Hellwig [this message]
2020-03-27 16:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327161754.GA19480@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.