From: Kees Cook <keescook@chromium.org>
To: Colin King <colin.king@canonical.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests/harness: fix spelling mistake "SIGARLM" -> "SIGALRM"
Date: Fri, 27 Mar 2020 19:02:25 +0000 [thread overview]
Message-ID: <202003271202.123FD50@keescook> (raw)
In-Reply-To: <20200327090648.13387-1-colin.king@canonical.com>
On Fri, Mar 27, 2020 at 09:06:48AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There a few identical spelling mistakes, fix these.
Argh, thanks Colin!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/kselftest_harness.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 2902f6a78f8a..2bb8c81fc0b4 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -705,7 +705,7 @@ static void __timeout_handler(int sig, siginfo_t *info, void *ucontext)
> /* Sanity check handler execution environment. */
> if (!t) {
> fprintf(TH_LOG_STREAM,
> - "no active test in SIGARLM handler!?\n");
> + "no active test in SIGALRM handler!?\n");
> abort();
> }
> if (sig != SIGALRM || sig != info->si_signo) {
> @@ -731,7 +731,7 @@ void __wait_for_test(struct __test_metadata *t)
> if (sigaction(SIGALRM, &action, &saved_action)) {
> t->passed = 0;
> fprintf(TH_LOG_STREAM,
> - "%s: unable to install SIGARLM handler\n",
> + "%s: unable to install SIGALRM handler\n",
> t->name);
> return;
> }
> @@ -743,7 +743,7 @@ void __wait_for_test(struct __test_metadata *t)
> if (sigaction(SIGALRM, &saved_action, NULL)) {
> t->passed = 0;
> fprintf(TH_LOG_STREAM,
> - "%s: unable to uninstall SIGARLM handler\n",
> + "%s: unable to uninstall SIGALRM handler\n",
> t->name);
> return;
> }
> --
> 2.25.1
>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Colin King <colin.king@canonical.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
Will Drewry <wad@chromium.org>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests/harness: fix spelling mistake "SIGARLM" -> "SIGALRM"
Date: Fri, 27 Mar 2020 12:02:25 -0700 [thread overview]
Message-ID: <202003271202.123FD50@keescook> (raw)
In-Reply-To: <20200327090648.13387-1-colin.king@canonical.com>
On Fri, Mar 27, 2020 at 09:06:48AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There a few identical spelling mistakes, fix these.
Argh, thanks Colin!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/kselftest_harness.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 2902f6a78f8a..2bb8c81fc0b4 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -705,7 +705,7 @@ static void __timeout_handler(int sig, siginfo_t *info, void *ucontext)
> /* Sanity check handler execution environment. */
> if (!t) {
> fprintf(TH_LOG_STREAM,
> - "no active test in SIGARLM handler!?\n");
> + "no active test in SIGALRM handler!?\n");
> abort();
> }
> if (sig != SIGALRM || sig != info->si_signo) {
> @@ -731,7 +731,7 @@ void __wait_for_test(struct __test_metadata *t)
> if (sigaction(SIGALRM, &action, &saved_action)) {
> t->passed = 0;
> fprintf(TH_LOG_STREAM,
> - "%s: unable to install SIGARLM handler\n",
> + "%s: unable to install SIGALRM handler\n",
> t->name);
> return;
> }
> @@ -743,7 +743,7 @@ void __wait_for_test(struct __test_metadata *t)
> if (sigaction(SIGALRM, &saved_action, NULL)) {
> t->passed = 0;
> fprintf(TH_LOG_STREAM,
> - "%s: unable to uninstall SIGARLM handler\n",
> + "%s: unable to uninstall SIGALRM handler\n",
> t->name);
> return;
> }
> --
> 2.25.1
>
--
Kees Cook
next prev parent reply other threads:[~2020-03-27 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 9:06 [PATCH][next] selftests/harness: fix spelling mistake "SIGARLM" -> "SIGALRM" Colin King
2020-03-27 19:02 ` Kees Cook [this message]
2020-03-27 19:02 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003271202.123FD50@keescook \
--to=keescook@chromium.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.