From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: use forced codec wake on all gen9+ platforms
Date: Fri, 27 Mar 2020 17:52:53 +0200 [thread overview]
Message-ID: <20200327155253.GH13686@intel.com> (raw)
In-Reply-To: <20200324153212.6303-1-kai.vehmanen@linux.intel.com>
On Tue, Mar 24, 2020 at 05:32:12PM +0200, Kai Vehmanen wrote:
> Commit 632f3ab95fe2 ("drm/i915/audio: add codec wakeup override
> enabled/disable callback"), added logic to toggle Codec Wake on gen9.
> This is used by audio driver when it resets the HDA controller.
>
> It seems explicit toggling of the wakeline can help to fix problems
> with probe failing on some gen12 platforms. And based on specs, there
> is no reason why this programming sequence should not be applied to all
> gen9+ platforms. No side-effects are seen on gen10/11. So apply
> the wake-logic to all gen9+ platforms.
>
> Link: https://github.com/thesofproject/linux/issues/1847
> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Pushed to dinq. Thanks.
> ---
> drivers/gpu/drm/i915/display/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
> index 62f234f641de..950160f1a89f 100644
> --- a/drivers/gpu/drm/i915/display/intel_audio.c
> +++ b/drivers/gpu/drm/i915/display/intel_audio.c
> @@ -931,7 +931,7 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
> unsigned long cookie;
> u32 tmp;
>
> - if (!IS_GEN(dev_priv, 9))
> + if (INTEL_GEN(dev_priv) < 9)
> return;
>
> cookie = i915_audio_component_get_power(kdev);
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-03-27 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:32 [Intel-gfx] [PATCH] drm/i915: use forced codec wake on all gen9+ platforms Kai Vehmanen
2020-03-24 16:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-24 18:39 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-27 15:52 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327155253.GH13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kai.vehmanen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.