* [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.
@ 2020-03-27 16:14 Mao Zhongyi
2020-03-27 18:02 ` Dr. David Alan Gilbert
2020-03-27 18:39 ` Stefano Garzarella
0 siblings, 2 replies; 4+ messages in thread
From: Mao Zhongyi @ 2020-03-27 16:14 UTC (permalink / raw)
To: qemu-devel; +Cc: dgilbert, Mao Zhongyi, sgarzare
When running:
(qemu) info migrate_parameters
announce-initial: 50 ms
announce-max: 550 ms
announce-step: 100 ms
compress-wait-thread: on
...
max-bandwidth: 33554432 bytes/second
downtime-limit: 300 milliseconds
x-checkpoint-delay: 20000
...
xbzrle-cache-size: 67108864
add units for the parameters 'x-checkpoint-delay' and
'xbzrle-cache-size', it's easier to read, also move
milliseconds to ms to keep the same style.
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
monitor/hmp-cmds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 2a900a528a..790fad3afe 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
params->max_bandwidth);
assert(params->has_downtime_limit);
- monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n",
+ monitor_printf(mon, "%s: %" PRIu64 " ms\n",
MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
params->downtime_limit);
assert(params->has_x_checkpoint_delay);
- monitor_printf(mon, "%s: %u\n",
+ monitor_printf(mon, "%s: %u ms\n",
MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY),
params->x_checkpoint_delay);
assert(params->has_block_incremental);
@@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "%s: %s\n",
MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION),
MultiFDCompression_str(params->multifd_compression));
- monitor_printf(mon, "%s: %" PRIu64 "\n",
+ monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
params->xbzrle_cache_size);
monitor_printf(mon, "%s: %" PRIu64 "\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.
2020-03-27 16:14 [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters Mao Zhongyi
@ 2020-03-27 18:02 ` Dr. David Alan Gilbert
2020-03-28 1:56 ` maozy
2020-03-27 18:39 ` Stefano Garzarella
1 sibling, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-03-27 18:02 UTC (permalink / raw)
To: Mao Zhongyi; +Cc: qemu-devel, sgarzare
* Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
> When running:
> (qemu) info migrate_parameters
> announce-initial: 50 ms
> announce-max: 550 ms
> announce-step: 100 ms
> compress-wait-thread: on
> ...
> max-bandwidth: 33554432 bytes/second
> downtime-limit: 300 milliseconds
> x-checkpoint-delay: 20000
> ...
> xbzrle-cache-size: 67108864
>
> add units for the parameters 'x-checkpoint-delay' and
> 'xbzrle-cache-size', it's easier to read, also move
> milliseconds to ms to keep the same style.
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Thanks
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(info migrate could also be fixed, but that's a separate issue)
> ---
> monitor/hmp-cmds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 2a900a528a..790fad3afe 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
> params->max_bandwidth);
> assert(params->has_downtime_limit);
> - monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n",
> + monitor_printf(mon, "%s: %" PRIu64 " ms\n",
> MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
> params->downtime_limit);
> assert(params->has_x_checkpoint_delay);
> - monitor_printf(mon, "%s: %u\n",
> + monitor_printf(mon, "%s: %u ms\n",
> MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY),
> params->x_checkpoint_delay);
> assert(params->has_block_incremental);
> @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "%s: %s\n",
> MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION),
> MultiFDCompression_str(params->multifd_compression));
> - monitor_printf(mon, "%s: %" PRIu64 "\n",
> + monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
> MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
> params->xbzrle_cache_size);
> monitor_printf(mon, "%s: %" PRIu64 "\n",
> --
> 2.17.1
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.
2020-03-27 16:14 [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters Mao Zhongyi
2020-03-27 18:02 ` Dr. David Alan Gilbert
@ 2020-03-27 18:39 ` Stefano Garzarella
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2020-03-27 18:39 UTC (permalink / raw)
To: Mao Zhongyi; +Cc: qemu-devel, dgilbert
On Sat, Mar 28, 2020 at 12:14:54AM +0800, Mao Zhongyi wrote:
> When running:
> (qemu) info migrate_parameters
> announce-initial: 50 ms
> announce-max: 550 ms
> announce-step: 100 ms
> compress-wait-thread: on
> ...
> max-bandwidth: 33554432 bytes/second
> downtime-limit: 300 milliseconds
> x-checkpoint-delay: 20000
> ...
> xbzrle-cache-size: 67108864
>
> add units for the parameters 'x-checkpoint-delay' and
> 'xbzrle-cache-size', it's easier to read, also move
> milliseconds to ms to keep the same style.
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> ---
> monitor/hmp-cmds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks,
Stefano
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 2a900a528a..790fad3afe 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
> params->max_bandwidth);
> assert(params->has_downtime_limit);
> - monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n",
> + monitor_printf(mon, "%s: %" PRIu64 " ms\n",
> MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
> params->downtime_limit);
> assert(params->has_x_checkpoint_delay);
> - monitor_printf(mon, "%s: %u\n",
> + monitor_printf(mon, "%s: %u ms\n",
> MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY),
> params->x_checkpoint_delay);
> assert(params->has_block_incremental);
> @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "%s: %s\n",
> MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION),
> MultiFDCompression_str(params->multifd_compression));
> - monitor_printf(mon, "%s: %" PRIu64 "\n",
> + monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
> MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
> params->xbzrle_cache_size);
> monitor_printf(mon, "%s: %" PRIu64 "\n",
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters.
2020-03-27 18:02 ` Dr. David Alan Gilbert
@ 2020-03-28 1:56 ` maozy
0 siblings, 0 replies; 4+ messages in thread
From: maozy @ 2020-03-28 1:56 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: qemu-devel, sgarzare
On 3/28/20 2:02 AM, Dr. David Alan Gilbert wrote:
> * Mao Zhongyi (maozhongyi@cmss.chinamobile.com) wrote:
>> When running:
>> (qemu) info migrate_parameters
>> announce-initial: 50 ms
>> announce-max: 550 ms
>> announce-step: 100 ms
>> compress-wait-thread: on
>> ...
>> max-bandwidth: 33554432 bytes/second
>> downtime-limit: 300 milliseconds
>> x-checkpoint-delay: 20000
>> ...
>> xbzrle-cache-size: 67108864
>>
>> add units for the parameters 'x-checkpoint-delay' and
>> 'xbzrle-cache-size', it's easier to read, also move
>> milliseconds to ms to keep the same style.
>>
>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>
> Thanks
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> (info migrate could also be fixed, but that's a separate issue)
Yes, will fix it in a separated patch.
Thanks,
Mao
>
>
>> ---
>> monitor/hmp-cmds.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
>> index 2a900a528a..790fad3afe 100644
>> --- a/monitor/hmp-cmds.c
>> +++ b/monitor/hmp-cmds.c
>> @@ -436,11 +436,11 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>> MigrationParameter_str(MIGRATION_PARAMETER_MAX_BANDWIDTH),
>> params->max_bandwidth);
>> assert(params->has_downtime_limit);
>> - monitor_printf(mon, "%s: %" PRIu64 " milliseconds\n",
>> + monitor_printf(mon, "%s: %" PRIu64 " ms\n",
>> MigrationParameter_str(MIGRATION_PARAMETER_DOWNTIME_LIMIT),
>> params->downtime_limit);
>> assert(params->has_x_checkpoint_delay);
>> - monitor_printf(mon, "%s: %u\n",
>> + monitor_printf(mon, "%s: %u ms\n",
>> MigrationParameter_str(MIGRATION_PARAMETER_X_CHECKPOINT_DELAY),
>> params->x_checkpoint_delay);
>> assert(params->has_block_incremental);
>> @@ -453,7 +453,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)
>> monitor_printf(mon, "%s: %s\n",
>> MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESSION),
>> MultiFDCompression_str(params->multifd_compression));
>> - monitor_printf(mon, "%s: %" PRIu64 "\n",
>> + monitor_printf(mon, "%s: %" PRIu64 " bytes\n",
>> MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE),
>> params->xbzrle_cache_size);
>> monitor_printf(mon, "%s: %" PRIu64 "\n",
>> --
>> 2.17.1
>>
>>
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-28 1:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-27 16:14 [PATCH v2] monitor/hmp-cmds: add units for migrate_parameters Mao Zhongyi
2020-03-27 18:02 ` Dr. David Alan Gilbert
2020-03-28 1:56 ` maozy
2020-03-27 18:39 ` Stefano Garzarella
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.