[PATCH] staging: sm750fb: line over 80 characters

[PATCH] staging: sm750fb: line over 80 characters

[Gokce Kuler]

Line is split from comma and add bottom line for 80 characters rule.

Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8f305c9..092f1c6 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -711,7 +711,9 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
 		} else {
 			output->paths = sm750_crt;
 			crtc->channel = sm750_primary;
-			/* not consider of padding stuffs for oScreen,need fix */
+			/* not consider of padding stuffs for oScreen,
+			 * need fix
+			 */
 			crtc->oScreen = sm750_dev->vidmem_size >> 1;
 			crtc->vScreen = sm750_dev->pvMem + crtc->oScreen;
 		}
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: sm750fb: line over 80 characters

[Julia Lawall]

On Sat, 28 Mar 2020, Gokce Kuler wrote:

> Line is split from comma and add bottom line for 80 characters rule.

"from comma" is not an important piece of information.  Since comments
aren't code, they can be split anywhere.

From the log message, it looks like you are doing two different things.
But the second one is actually necessary because you have converted a
single line comment to a multiline comment.

It would probably be clear enough just to say:

Convert a single line comment to a multiline comment to respect the 80
character rule.

Problem found using checkpatch. (if that was the case)

julia


>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 8f305c9..092f1c6 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -711,7 +711,9 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
>  		} else {
>  			output->paths = sm750_crt;
>  			crtc->channel = sm750_primary;
> -			/* not consider of padding stuffs for oScreen,need fix */
> +			/* not consider of padding stuffs for oScreen,
> +			 * need fix
> +			 */
>  			crtc->oScreen = sm750_dev->vidmem_size >> 1;
>  			crtc->vScreen = sm750_dev->pvMem + crtc->oScreen;
>  		}
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200328001552.GA14914%40siyah2.
>