From: Wei Liu <wl@xen.org>
To: Julien Grall <julien@xen.org>
Cc: "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Julien Grall" <jgrall@amazon.com>,
"Jan Beulich" <jbeulich@suse.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register()
Date: Sat, 28 Mar 2020 11:01:38 +0000 [thread overview]
Message-ID: <20200328110138.inohkfimiiij73vk@debian> (raw)
In-Reply-To: <20200327190546.21580-2-julien@xen.org>
On Fri, Mar 27, 2020 at 07:05:44PM +0000, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> bad_ioapic_register() is return a bool, so we should switch to
> true/false.
is return -> returns / is returning
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
Reviewed-by: Wei Liu <wl@xen.org>
next prev parent reply other threads:[~2020-03-28 11:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 19:05 [Xen-devel] [PATCH 0/3] xen/x86: Simplify ioapic_init() Julien Grall
2020-03-27 19:05 ` [Xen-devel] [PATCH 1/3] xen/x86: ioapic: Use true/false in bad_ioapic_register() Julien Grall
2020-03-28 11:01 ` Wei Liu [this message]
2020-03-31 11:05 ` Jan Beulich
2020-03-27 19:05 ` [Xen-devel] [PATCH 2/3] xen/x86: ioapic: Rename init_ioapic_mappings() to init_ioapic() Julien Grall
2020-03-30 10:37 ` Roger Pau Monné
2020-03-30 12:55 ` Julien Grall
2020-03-31 11:08 ` Jan Beulich
2020-03-27 19:05 ` [Xen-devel] [PATCH 3/3] xen/x86: ioapic: Simplify ioapic_init() Julien Grall
2020-03-29 14:35 ` Wei Liu
2020-03-29 15:54 ` Julien Grall
2020-03-30 10:43 ` Roger Pau Monné
2020-03-30 12:56 ` Julien Grall
2020-03-31 11:22 ` Jan Beulich
2020-03-31 11:51 ` Julien Grall
2020-03-31 12:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328110138.inohkfimiiij73vk@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.