* [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check
@ 2020-03-28 10:41 Oliver Barta
2020-03-29 14:17 ` Ramalingam C
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Oliver Barta @ 2020-03-28 10:41 UTC (permalink / raw)
To: Ramalingam C, intel-gfx, Jani Nikula, Joonas Lahtinen
Cc: Daniel Vetter, Oliver Barta, Ravisankar Madasamy, Sean Paul,
Chris Wilson
From: Oliver Barta <oliver.barta@aptiv.com>
The check was always succeeding even in case of a mismatch due to the
HDCP_STATUS_ENC bit being set. Make sure both bits are actually set.
Signed-off-by: Oliver Barta <oliver.barta@aptiv.com>
Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
---
[v2] rebased on top of latest changes
drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 0076abc63851..51a69f330588 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1561,7 +1561,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg);
/* Wait for Ri prime match */
- if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) &
+ if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder,
+ port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
(HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) {
drm_err(&i915->drm,
"Ri' mismatch detected, link check failed (%x)\n",
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check
2020-03-28 10:41 [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta
@ 2020-03-29 14:17 ` Ramalingam C
2020-04-16 9:53 ` Jani Nikula
2020-03-30 16:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HDCP: fix Ri prime check done during link check (rev2) Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Ramalingam C @ 2020-03-29 14:17 UTC (permalink / raw)
To: Oliver Barta
Cc: Daniel Vetter, intel-gfx, Sean Paul, Oliver Barta,
Ravisankar Madasamy
On 2020-03-28 at 11:41:00 +0100, Oliver Barta wrote:
> From: Oliver Barta <oliver.barta@aptiv.com>
>
> The check was always succeeding even in case of a mismatch due to the
> HDCP_STATUS_ENC bit being set. Make sure both bits are actually set.
>
Looks good to me:
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Oliver Barta <oliver.barta@aptiv.com>
> Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
> ---
> [v2] rebased on top of latest changes
>
> drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 0076abc63851..51a69f330588 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1561,7 +1561,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
> intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg);
>
> /* Wait for Ri prime match */
> - if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) &
> + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder,
> + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
> (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) {
> drm_err(&i915->drm,
> "Ri' mismatch detected, link check failed (%x)\n",
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HDCP: fix Ri prime check done during link check (rev2)
2020-03-28 10:41 [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta
2020-03-29 14:17 ` Ramalingam C
@ 2020-03-30 16:42 ` Patchwork
2020-03-30 17:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-31 5:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-30 16:42 UTC (permalink / raw)
To: Oliver Barta; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: HDCP: fix Ri prime check done during link check (rev2)
URL : https://patchwork.freedesktop.org/series/74152/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e4fabe623ddb drm/i915: HDCP: fix Ri prime check done during link check
-:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#22: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1565:
+ if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder,
+ port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
total: 0 errors, 0 warnings, 1 checks, 9 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: HDCP: fix Ri prime check done during link check (rev2)
2020-03-28 10:41 [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta
2020-03-29 14:17 ` Ramalingam C
2020-03-30 16:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HDCP: fix Ri prime check done during link check (rev2) Patchwork
@ 2020-03-30 17:07 ` Patchwork
2020-03-31 5:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-30 17:07 UTC (permalink / raw)
To: Oliver Barta; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: HDCP: fix Ri prime check done during link check (rev2)
URL : https://patchwork.freedesktop.org/series/74152/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8214 -> Patchwork_17130
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/index.html
Known issues
------------
Here are the changes found in Patchwork_17130 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-cfl-8109u: [PASS][1] -> [INCOMPLETE][2] ([i915#1430] / [i915#656])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/fi-cfl-8109u/igt@i915_selftest@live@execlists.html
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#656])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/fi-apl-guc/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/fi-apl-guc/igt@i915_selftest@live@execlists.html
[i915#1430]: https://gitlab.freedesktop.org/drm/intel/issues/1430
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
Participating hosts (45 -> 40)
------------------------------
Additional (4): fi-kbl-soraka fi-byt-n2820 fi-bwr-2160 fi-snb-2520m
Missing (9): fi-cml-u2 fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-elk-e7500 fi-icl-guc fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8214 -> Patchwork_17130
CI-20190529: 20190529
CI_DRM_8214: a2b99403233148c1940fc972caef2a5c456d11b2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5545: 9e5bfd10d56f81b98e0229c6bb14670221fd0b54 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17130: e4fabe623ddbb9cc86fcd304182bc0f6c2bde4a1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e4fabe623ddb drm/i915: HDCP: fix Ri prime check done during link check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: HDCP: fix Ri prime check done during link check (rev2)
2020-03-28 10:41 [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta
` (2 preceding siblings ...)
2020-03-30 17:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-03-31 5:15 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-03-31 5:15 UTC (permalink / raw)
To: Oliver Barta; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: HDCP: fix Ri prime check done during link check (rev2)
URL : https://patchwork.freedesktop.org/series/74152/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8214_full -> Patchwork_17130_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17130_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +13 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb2/igt@gem_busy@busy-vcs1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd2:
- shard-kbl: [PASS][3] -> [FAIL][4] ([i915#1528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-kbl7/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd2.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-kbl3/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd2.html
* igt@gem_exec_schedule@implicit-read-write-bsd2:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276] / [i915#677])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb2/igt@gem_exec_schedule@implicit-read-write-bsd2.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@gem_exec_schedule@implicit-read-write-bsd2.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#677])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb3/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb1/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#112146]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb3/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd2:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +19 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd2.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][13] -> [TIMEOUT][14] ([i915#1526])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-hsw7/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#151] / [i915#69])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-skl9/igt@i915_pm_rpm@system-suspend-modeset.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-skl10/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +5 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#72])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#117] / [i915#133])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-glk3/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-glk5/igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#52] / [i915#54])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-glk2/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#79])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-glk2/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#180])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-apl8/igt@kms_flip@flip-vs-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-apl6/igt@kms_flip@flip-vs-suspend.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109642] / [fdo#111068])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Possible fixes ####
* igt@gem_busy@extended-parallel-vcs1:
- shard-iclb: [SKIP][35] ([fdo#112080]) -> [PASS][36] +10 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb6/igt@gem_busy@extended-parallel-vcs1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb4/igt@gem_busy@extended-parallel-vcs1.html
* igt@gem_exec_schedule@implicit-read-write-bsd1:
- shard-iclb: [SKIP][37] ([fdo#109276] / [i915#677]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb3/igt@gem_exec_schedule@implicit-read-write-bsd1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb1/igt@gem_exec_schedule@implicit-read-write-bsd1.html
* igt@gem_exec_schedule@pi-common-bsd:
- shard-iclb: [SKIP][39] ([i915#677]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb2/igt@gem_exec_schedule@pi-common-bsd.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@gem_exec_schedule@pi-common-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +18 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb8/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@i915_selftest@live@requests:
- shard-iclb: [INCOMPLETE][45] ([i915#1505]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb8/igt@i915_selftest@live@requests.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb3/igt@i915_selftest@live@requests.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][47] ([i915#180]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-apl6/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-WARN][49] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-kbl1/igt@kms_fbcon_fbt@fbc-suspend.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-apl: [FAIL][51] ([i915#46]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +7 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][55] ([fdo#108145]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@cursor_render:
- shard-tglb: [SKIP][57] ([i915#668]) -> [PASS][58] +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-tglb6/igt@kms_psr@cursor_render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-tglb6/igt@kms_psr@cursor_render.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][59] ([fdo#109441]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][61] ([i915#31]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-apl4/igt@kms_setmode@basic.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-apl1/igt@kms_setmode@basic.html
#### Warnings ####
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][63] ([i915#468]) -> [FAIL][64] ([i915#454])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-tglb5/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-iclb: [INCOMPLETE][65] ([i915#189]) -> [SKIP][66] ([i915#1316])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8214/shard-iclb4/igt@i915_pm_rpm@debugfs-forcewake-user.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/shard-iclb4/igt@i915_pm_rpm@debugfs-forcewake-user.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#117]: https://gitlab.freedesktop.org/drm/intel/issues/117
[i915#1316]: https://gitlab.freedesktop.org/drm/intel/issues/1316
[i915#133]: https://gitlab.freedesktop.org/drm/intel/issues/133
[i915#1505]: https://gitlab.freedesktop.org/drm/intel/issues/1505
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1526]: https://gitlab.freedesktop.org/drm/intel/issues/1526
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#189]: https://gitlab.freedesktop.org/drm/intel/issues/189
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8214 -> Patchwork_17130
CI-20190529: 20190529
CI_DRM_8214: a2b99403233148c1940fc972caef2a5c456d11b2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5545: 9e5bfd10d56f81b98e0229c6bb14670221fd0b54 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17130: e4fabe623ddbb9cc86fcd304182bc0f6c2bde4a1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17130/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check
2020-03-29 14:17 ` Ramalingam C
@ 2020-04-16 9:53 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2020-04-16 9:53 UTC (permalink / raw)
To: Ramalingam C, Oliver Barta
Cc: Daniel Vetter, intel-gfx, Ravisankar Madasamy, Sean Paul,
Oliver Barta, Chris Wilson
On Sun, 29 Mar 2020, Ramalingam C <ramalingam.c@intel.com> wrote:
> On 2020-03-28 at 11:41:00 +0100, Oliver Barta wrote:
>> From: Oliver Barta <oliver.barta@aptiv.com>
>>
>> The check was always succeeding even in case of a mismatch due to the
>> HDCP_STATUS_ENC bit being set. Make sure both bits are actually set.
>>
> Looks good to me:
>
> Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
Pushed to dinq, thanks for the patch and review.
Fixed the checkpatch indentation warning while at it.
BR,
Jani.
>> Signed-off-by: Oliver Barta <oliver.barta@aptiv.com>
>> Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
>> ---
>> [v2] rebased on top of latest changes
>>
>> drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> index 0076abc63851..51a69f330588 100644
>> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
>> @@ -1561,7 +1561,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
>> intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg);
>>
>> /* Wait for Ri prime match */
>> - if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) &
>> + if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder,
>> + port)) & (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
>> (HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) {
>> drm_err(&i915->drm,
>> "Ri' mismatch detected, link check failed (%x)\n",
>> --
>> 2.20.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-16 9:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-28 10:41 [Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check Oliver Barta
2020-03-29 14:17 ` Ramalingam C
2020-04-16 9:53 ` Jani Nikula
2020-03-30 16:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: HDCP: fix Ri prime check done during link check (rev2) Patchwork
2020-03-30 17:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-31 5:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.