From: Stefano Brivio <sbrivio@redhat.com>
To: Sam Muhammed <jane.pnx9@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 2/7] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().
Date: Mon, 30 Mar 2020 03:04:33 +0200 [thread overview]
Message-ID: <20200330030433.4b924c5e@elisabeth> (raw)
In-Reply-To: <bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585143581.git.jane.pnx9@gmail.com>
On Wed, 25 Mar 2020 10:26:37 -0400
Sam Muhammed <jane.pnx9@gmail.com> wrote:
> kzalloc(sizeof(*var), ...) was the format been used
> across the driver, which is the preferred format,
> but missed two instances, correct them to match the
> coding standards.
>
> Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...)
> over kzalloc(sizeof(struct var)...)
>
> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> ---
> Changes in v2:
> - Update the log message to be more descriptive.
It would be nicer to refer here to the person who suggested the change,
if it's not you directly noticing the problem (you can just mention
them by name, name and surname, or explicitly say "suggested by ...",
"requested by ...", etc). There are many recent examples on this list.
--
Stefano
next prev parent reply other threads:[~2020-03-30 1:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 14:26 [PATCH v2 0/7] Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 1/7] Staging: kpc2000: kpc_dma: Remove comparison to NULL Sam Muhammed
2020-03-30 1:04 ` [Outreachy kernel] " Stefano Brivio
2020-03-30 10:48 ` Sam Muhammed
2020-03-30 10:58 ` Julia Lawall
2020-03-30 11:02 ` Sam Muhammed
2020-03-30 13:55 ` Stefano Brivio
2020-03-30 16:33 ` Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 2/7] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc() Sam Muhammed
2020-03-30 1:04 ` Stefano Brivio [this message]
2020-03-30 10:45 ` [Outreachy kernel] " Sam Muhammed
2020-03-30 12:56 ` Stefano Brivio
2020-03-30 13:10 ` Sam Muhammed
2020-03-30 13:51 ` Stefano Brivio
2020-03-25 14:26 ` [PATCH v2 3/7] Staging: kpc2000: kpc_dma: Remove unnecessary braces Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 4/7] Staging: kpc2000: kpc_dma: Include the preferred header Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 5/7] Staging: kpc2000: kpc_dma: Use the SPDK comment style Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 6/7] Staging: kpc2000: kpc_dma: Use kcalloc over kzalloc Sam Muhammed
2020-03-25 14:26 ` [PATCH v2 7/7] Staging: kpc2000: kpc_dma: Use spaces around operators Sam Muhammed
2020-03-30 1:04 ` [Outreachy kernel] [PATCH v2 0/7] Staging: kpc2000: kpc_dma: Clear Misc Checkpatch.pl WARNINGS Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330030433.4b924c5e@elisabeth \
--to=sbrivio@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jane.pnx9@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.