Re: [Outreachy kernel] [PATCH v2 2/7] Staging: kpc2000: kpc_dma: Use sizeof(*var) in kzalloc().

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 30 Mar 2020 06:45:00 -0400
Sam Muhammed <jane.pnx9@gmail.com> wrote:

> On Mon, 2020-03-30 at 03:04 +0200, Stefano Brivio wrote:
> > On Wed, 25 Mar 2020 10:26:37 -0400
> > Sam Muhammed <jane.pnx9@gmail.com> wrote:
> >   
> > > kzalloc(sizeof(*var), ...) was the format been used
> > > across the driver, which is the preferred format,
> > > but missed two instances, correct them to match the
> > > coding standards.
> > > 
> > > Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...)
> > > over kzalloc(sizeof(struct var)...)
> > > 
> > > Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> > > ---
> > > Changes in v2:
> > > - Update the log message to be more descriptive.  
> > 
> > It would be nicer to refer here to the person who suggested the change,
> > if it's not you directly noticing the problem (you can just mention
> > them by name, name and surname, or explicitly say "suggested by ...",
> > "requested by ...", etc). There are many recent examples on this list.
> >   
> Ohh, Sorry for that, i thought this tag is more of a code related
> change. since being new to the process, most of the time log messages
> and subject lines will be commented on to follow the conventions. which
> i thought is a different case than changes in the patch itself.

Wait, I wasn't talking about tags here:

- use a Suggested-by: tag if the patch itself was suggested by somebody
  (which is not the case for this patch)

- v2 was prompted by comments you received for v1 by Julia, so it would
  be appropriate to state, in the history of log changes:
	- Update the log message to be more descriptive (suggested by
	  Julia Lawall)

-- 
Stefano