From: Greg KH <greg@kroah.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: stable@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: Stable request: iwlwifi: mvm: fix non-ACPI function
Date: Mon, 30 Mar 2020 10:50:07 +0200 [thread overview]
Message-ID: <20200330085007.GA239298@kroah.com> (raw)
In-Reply-To: <CAKf6xpub_isHjErmj=7yoxeo=2+CKOm+w8b=AWxE-KLJG5d2Dg@mail.gmail.com>
On Sun, Mar 29, 2020 at 03:17:32PM -0400, Jason Andryuk wrote:
> On Sun, Mar 29, 2020 at 2:41 PM Jason Andryuk <jandryuk@gmail.com> wrote:
> >
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > commit 7937fd3227055892e169f4b34d21157e57d919e2 upstream.
> >
> > The code now compiles without ACPI, but there's a warning since
> > iwl_mvm_get_ppag_table() isn't used, and iwl_mvm_ppag_init() must
> > not unconditionally fail but return success instead.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> > [Drop hunk removing iwl_mvm_get_ppag_table() since it doesn't exist in
> > 5.4]
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> > ---
> > A 5.4 kernel can't "up" an iwlwifi interface when CONFIG_ACPI=n.
> > `wpa_supplicant` or `ip link set wlan0 up` return "No such file or
> > directory". The non-acpi stub iwl_mvm_ppag_init() always returns
> > -ENOENT which means iwl_mvm_up() always fails. Backporting the commit
> > lets iwl_mvm_up() succeed.
>
> This stable request is only applicable to 5.4
>
> Fixes 6ce1e5c0c207 "iwlwifi: support per-platform antenna gain"
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-03-30 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 18:41 Stable request: iwlwifi: mvm: fix non-ACPI function Jason Andryuk
2020-03-29 19:17 ` Jason Andryuk
2020-03-30 8:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330085007.GA239298@kroah.com \
--to=greg@kroah.com \
--cc=jandryuk@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=luciano.coelho@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.