[Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Soumyajit Deb]

Remove unnecessary extra blank lines to improve code readability and to
adhere to the Linux Kernel coding style.
Reported by checkpatch.pl

Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
---
 drivers/staging/qlge/qlge_mpi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
index 60c08d9cc034..b30992825612 100644
--- a/drivers/staging/qlge/qlge_mpi.c
+++ b/drivers/staging/qlge/qlge_mpi.c
@@ -119,7 +119,6 @@ int ql_own_firmware(struct ql_adapter *qdev)
 		return 1;
 
 	return 0;
-
 }
 
 static int ql_get_mb_sts(struct ql_adapter *qdev, struct mbox_params *mbcp)
@@ -358,7 +357,6 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
 		for (i = 0; i < mbcp->out_count; i++)
 			netif_err(qdev, drv, qdev->ndev, "mbox_out[%d] = 0x%.08x.\n",
 				  i, mbcp->mbox_out[i]);
-
 	}
 
 	return status;
@@ -406,7 +404,6 @@ static int ql_mpi_handler(struct ql_adapter *qdev, struct mbox_params *mbcp)
 	}
 
 	switch (mbcp->mbox_out[0]) {
-
 	/* This case is only active when we arrive here
 	 * as a result of issuing a mailbox command to
 	 * the firmware.
-- 
2.17.1

Re: [Outreachy kernel] [Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Stefano Brivio]

On Mon, 30 Mar 2020 10:43:43 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:

> Remove unnecessary extra blank lines to improve code readability and to
> adhere to the Linux Kernel coding style.
> Reported by checkpatch.pl
> 
> Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>

This looks good to me, but why isn't it in a series with the next patch
you sent? They touch the same driver with similar purposes...

-- 
Stefano

Re: [Outreachy kernel] [Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Soumyajit Deb]

On Mon, Mar 30, 2020 at 08:07:24PM +0200, Stefano Brivio wrote:
> On Mon, 30 Mar 2020 10:43:43 +0530
> Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> 
> > Remove unnecessary extra blank lines to improve code readability and to
> > adhere to the Linux Kernel coding style.
> > Reported by checkpatch.pl
> > 
> > Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>
> 
> This looks good to me, but why isn't it in a series with the next patch
> you sent? They touch the same driver with similar purposes...
> 
> -- 
> Stefano

Should I resend this patch along with the other patches concerning the same
driver as a patch series?

--
Soumyajit

>

Re: [Outreachy kernel] [Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Stefano Brivio]

On Wed, 1 Apr 2020 00:37:28 +0530
Soumyajit Deb <debsoumyajit100@gmail.com> wrote:

> On Mon, Mar 30, 2020 at 08:07:24PM +0200, Stefano Brivio wrote:
> > On Mon, 30 Mar 2020 10:43:43 +0530
> > Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> >   
> > > Remove unnecessary extra blank lines to improve code readability and to
> > > adhere to the Linux Kernel coding style.
> > > Reported by checkpatch.pl
> > > 
> > > Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>  
> > 
> > This looks good to me, but why isn't it in a series with the next patch
> > you sent? They touch the same driver with similar purposes...
> > 
> > -- 
> > Stefano  
> 
> Should I resend this patch along with the other patches concerning the same
> driver as a patch series?

Yes, exactly -- it's just another invocation of git format-patch, you're
almost there.

-- 
Stefano

Re: [Outreachy kernel] [Outreachy] [PATCH] staging: qlge: Remove extra blank lines

[Soumyajit Deb]

On Wed, Apr 01, 2020 at 04:49:48AM +0200, Stefano Brivio wrote:
> On Wed, 1 Apr 2020 00:37:28 +0530
> Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> 
> > On Mon, Mar 30, 2020 at 08:07:24PM +0200, Stefano Brivio wrote:
> > > On Mon, 30 Mar 2020 10:43:43 +0530
> > > Soumyajit Deb <debsoumyajit100@gmail.com> wrote:
> > >   
> > > > Remove unnecessary extra blank lines to improve code readability and to
> > > > adhere to the Linux Kernel coding style.
> > > > Reported by checkpatch.pl
> > > > 
> > > > Signed-off-by: Soumyajit Deb <debsoumyajit100@gmail.com>  
> > > 
> > > This looks good to me, but why isn't it in a series with the next patch
> > > you sent? They touch the same driver with similar purposes...
> > > 
> > > -- 
> > > Stefano  
> > 
> > Should I resend this patch along with the other patches concerning the same
> > driver as a patch series?
> 
> Yes, exactly -- it's just another invocation of git format-patch, you're
> almost there.
> 
> -- 
> Stefano

Okay, I will send this patch and the patch after that as a patch series.
Thank you.

--
Soumyajit

>