From: Boris Brezillon <boris.brezillon@collabora.com>
To: Weijie Gao <weijie.gao@mediatek.com>
Cc: <linux-mtd@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anders Roxell <anders.roxell@linaro.org>,
Brendan Higgins <brendanhiggins@google.com>,
Piotr Sroka <piotrs@cadence.com>,
Mason Yang <masonccyang@mxic.com.tw>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller
Date: Tue, 31 Mar 2020 20:47:16 +0200 [thread overview]
Message-ID: <20200331204716.52f611db@collabora.com> (raw)
In-Reply-To: <1585678079-5999-1-git-send-email-weijie.gao@mediatek.com>
On Wed, 1 Apr 2020 02:07:58 +0800
Weijie Gao <weijie.gao@mediatek.com> wrote:
> This patch adds NAND flash controller driver for MediaTek MT7621 SoC.
>
> The NAND flash controller is similar with controllers described in
> mtk_nand.c, except that the controller from MT7621 doesn't support DMA
> transmission, and some registers' offset and fields are different.
>
Please don't duplicate driver the driver for those minor differences:
use regmap/reg_field to abstract reg field positions and make the DMA
optional.
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Weijie Gao <weijie.gao@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Brendan Higgins <brendanhiggins@google.com>,
linux-kernel@vger.kernel.org,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-mips@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mtd@lists.infradead.org,
Mason Yang <masonccyang@mxic.com.tw>,
Piotr Sroka <piotrs@cadence.com>
Subject: Re: [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller
Date: Tue, 31 Mar 2020 20:47:16 +0200 [thread overview]
Message-ID: <20200331204716.52f611db@collabora.com> (raw)
In-Reply-To: <1585678079-5999-1-git-send-email-weijie.gao@mediatek.com>
On Wed, 1 Apr 2020 02:07:58 +0800
Weijie Gao <weijie.gao@mediatek.com> wrote:
> This patch adds NAND flash controller driver for MediaTek MT7621 SoC.
>
> The NAND flash controller is similar with controllers described in
> mtk_nand.c, except that the controller from MT7621 doesn't support DMA
> transmission, and some registers' offset and fields are different.
>
Please don't duplicate driver the driver for those minor differences:
use regmap/reg_field to abstract reg field positions and make the DMA
optional.
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Weijie Gao <weijie.gao@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Brendan Higgins <brendanhiggins@google.com>,
linux-kernel@vger.kernel.org,
Frieder Schrempf <frieder.schrempf@kontron.de>,
linux-mips@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mtd@lists.infradead.org,
Mason Yang <masonccyang@mxic.com.tw>,
Piotr Sroka <piotrs@cadence.com>
Subject: Re: [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller
Date: Tue, 31 Mar 2020 20:47:16 +0200 [thread overview]
Message-ID: <20200331204716.52f611db@collabora.com> (raw)
In-Reply-To: <1585678079-5999-1-git-send-email-weijie.gao@mediatek.com>
On Wed, 1 Apr 2020 02:07:58 +0800
Weijie Gao <weijie.gao@mediatek.com> wrote:
> This patch adds NAND flash controller driver for MediaTek MT7621 SoC.
>
> The NAND flash controller is similar with controllers described in
> mtk_nand.c, except that the controller from MT7621 doesn't support DMA
> transmission, and some registers' offset and fields are different.
>
Please don't duplicate driver the driver for those minor differences:
use regmap/reg_field to abstract reg field positions and make the DMA
optional.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-03-31 18:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 18:07 [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller Weijie Gao
2020-03-31 18:07 ` Weijie Gao
2020-03-31 18:07 ` Weijie Gao
2020-03-31 18:07 ` [PATCH 2/2] dt-bindings: add documentation for mt7621-nand driver Weijie Gao
2020-03-31 18:07 ` Weijie Gao
2020-03-31 18:07 ` Weijie Gao
2020-03-31 22:00 ` Rob Herring
2020-03-31 22:00 ` Rob Herring
2020-03-31 22:00 ` Rob Herring
2020-03-31 18:47 ` Boris Brezillon [this message]
2020-03-31 18:47 ` [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand flash controller Boris Brezillon
2020-03-31 18:47 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331204716.52f611db@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=bbrezillon@kernel.org \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=matthias.bgg@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=piotrs@cadence.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.