From: Gokce Kuler <gokcekuler@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, rspringer@google.com,
toddpoynor@google.com, benchan@chromium.org
Subject: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
Date: Wed, 1 Apr 2020 02:09:40 +0300 [thread overview]
Message-ID: <20200331230940.GA12376@siyah2> (raw)
Since octal permissions is preffered to symbolic permissions,
octal permissions is used.Problem found checkpatch.pl.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index 1d0eed6..28dc422 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.7.4
next reply other threads:[~2020-03-31 23:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 23:09 Gokce Kuler [this message]
2020-04-01 3:01 ` [Outreachy kernel] [PATCH] staging: gasket: using octal permissions instead of symbolic permissions Stefano Brivio
2020-04-01 5:56 ` Greg KH
2020-04-02 12:20 ` Gokce Kuler
2020-04-02 12:43 ` [Outreachy kernel] " Julia Lawall
2020-04-02 13:18 ` Gokce Kuler
2020-04-02 13:30 ` Greg KH
2020-04-02 13:54 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331230940.GA12376@siyah2 \
--to=gokcekuler@gmail.com \
--cc=benchan@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=rspringer@google.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.