* [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
@ 2020-03-31 23:09 Gokce Kuler
2020-04-01 3:01 ` [Outreachy kernel] " Stefano Brivio
2020-04-01 5:56 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Gokce Kuler @ 2020-03-31 23:09 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, rspringer, toddpoynor, benchan
Since octal permissions is preffered to symbolic permissions,
octal permissions is used.Problem found checkpatch.pl.
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index 1d0eed6..28dc422 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-03-31 23:09 [PATCH] staging: gasket: using octal permissions instead of symbolic permissions Gokce Kuler
@ 2020-04-01 3:01 ` Stefano Brivio
2020-04-01 5:56 ` Greg KH
1 sibling, 0 replies; 8+ messages in thread
From: Stefano Brivio @ 2020-04-01 3:01 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh, rspringer, toddpoynor, benchan
On Wed, 1 Apr 2020 02:09:40 +0300
Gokce Kuler <gokcekuler@gmail.com> wrote:
> Since octal permissions is preffered to symbolic permissions,
> octal permissions is used.Problem found checkpatch.pl.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-03-31 23:09 [PATCH] staging: gasket: using octal permissions instead of symbolic permissions Gokce Kuler
2020-04-01 3:01 ` [Outreachy kernel] " Stefano Brivio
@ 2020-04-01 5:56 ` Greg KH
2020-04-02 12:20 ` Gokce Kuler
1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2020-04-01 5:56 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, rspringer, toddpoynor, benchan
On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> Since octal permissions is preffered to symbolic permissions,
> octal permissions is used.Problem found checkpatch.pl.
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/gasket/gasket_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index 1d0eed6..28dc422 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
Why not use __ATTR_RO() instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-04-01 5:56 ` Greg KH
@ 2020-04-02 12:20 ` Gokce Kuler
2020-04-02 12:43 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 8+ messages in thread
From: Gokce Kuler @ 2020-04-02 12:20 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel, Rob Springer, Todd Poynor, benchan
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
checkpatch.pl did not show any warning about this. Can I add the permission
head to __ATTR_RO() ?
Greg KH <gregkh@linuxfoundation.org>, 1 Nis 2020 Çar, 08:56 tarihinde şunu
yazdı:
> On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> > Since octal permissions is preffered to symbolic permissions,
> > octal permissions is used.Problem found checkpatch.pl.
> >
> > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > ---
> > drivers/staging/gasket/gasket_sysfs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> b/drivers/staging/gasket/gasket_sysfs.h
> > index 1d0eed6..28dc422 100644
> > --- a/drivers/staging/gasket/gasket_sysfs.h
> > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> >
> > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> > {
> \
> > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),
> \
> > + .attr = __ATTR(_name, 0444, _show_function, NULL),
> \
>
> Why not use __ATTR_RO() instead?
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 1890 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-04-02 12:20 ` Gokce Kuler
@ 2020-04-02 12:43 ` Julia Lawall
2020-04-02 13:18 ` Gokce Kuler
0 siblings, 1 reply; 8+ messages in thread
From: Julia Lawall @ 2020-04-02 12:43 UTC (permalink / raw)
To: Gokce Kuler; +Cc: Greg KH, outreachy-kernel, Rob Springer, Todd Poynor, benchan
[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]
On Thu, 2 Apr 2020, Gokce Kuler wrote:
> checkpatch.pl did not show any warning about this. Can I add the permission head to __ATTR_RO() ?
What do you mean by permission head?
julia
>
> Greg KH <gregkh@linuxfoundation.org>, 1 Nis 2020 Çar, 08:56 tarihinde şunu yazdı:
> On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> > Since octal permissions is preffered to symbolic permissions,
> > octal permissions is used.Problem found checkpatch.pl.
> >
> > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > ---
> > drivers/staging/gasket/gasket_sysfs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> > index 1d0eed6..28dc422 100644
> > --- a/drivers/staging/gasket/gasket_sysfs.h
> > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> >
> > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> > { \
> > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> > + .attr = __ATTR(_name, 0444, _show_function, NULL), \
>
> Why not use __ATTR_RO() instead?
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/CAL9LiB%2BPSd68yRfkrbr9yHkShzuPceJHosvswETO1-w1zgkqFw%40mail.gmail.com.
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-04-02 12:43 ` [Outreachy kernel] " Julia Lawall
@ 2020-04-02 13:18 ` Gokce Kuler
2020-04-02 13:30 ` Greg KH
2020-04-02 13:54 ` Julia Lawall
0 siblings, 2 replies; 8+ messages in thread
From: Gokce Kuler @ 2020-04-02 13:18 UTC (permalink / raw)
To: Julia Lawall
Cc: Greg KH, outreachy-kernel, Rob Springer, Todd Poynor, benchan
[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]
Can I edit like #define GASKET_SYSFS_RO(_name,_permission_, _show_function,
_attr_type) ?
Julia Lawall <julia.lawall@inria.fr>, 2 Nis 2020 Per, 15:43 tarihinde şunu
yazdı:
> On Thu, 2 Apr 2020, Gokce Kuler wrote:
>
> > checkpatch.pl did not show any warning about this. Can I add the
> permission head to __ATTR_RO() ?
>
> What do you mean by permission head?
>
> julia
>
> >
> > Greg KH <gregkh@linuxfoundation.org>, 1 Nis 2020 Çar, 08:56 tarihinde
> şunu yazdı:
> > On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> > > Since octal permissions is preffered to symbolic permissions,
> > > octal permissions is used.Problem found checkpatch.pl.
> > >
> > > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > > ---
> > > drivers/staging/gasket/gasket_sysfs.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/gasket/gasket_sysfs.h
> b/drivers/staging/gasket/gasket_sysfs.h
> > > index 1d0eed6..28dc422 100644
> > > --- a/drivers/staging/gasket/gasket_sysfs.h
> > > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > >
> > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)
> \
> > > {
> \
> > > - .attr = __ATTR(_name, S_IRUGO, _show_function,
> NULL), \
> > > + .attr = __ATTR(_name, 0444, _show_function,
> NULL), \
> >
> > Why not use __ATTR_RO() instead?
> >
> > thanks,
> >
> > greg k-h
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/outreachy-kernel/CAL9LiB%2BPSd68yRfkrbr9yHkShzuPceJHosvswETO1-w1zgkqFw%40mail.gmail.com
> .
> >
> >
[-- Attachment #2: Type: text/html, Size: 3392 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-04-02 13:18 ` Gokce Kuler
@ 2020-04-02 13:30 ` Greg KH
2020-04-02 13:54 ` Julia Lawall
1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2020-04-02 13:30 UTC (permalink / raw)
To: Gokce Kuler
Cc: Julia Lawall, outreachy-kernel, Rob Springer, Todd Poynor,
benchan
On Thu, Apr 02, 2020 at 04:18:05PM +0300, Gokce Kuler wrote:
> Can I edit like #define GASKET_SYSFS_RO(_name,_permission_, _show_function,
> _attr_type) ?
As you seem to have lost the context of the email here, I'm sorry, but I
have no idea what you are referring to.
Remember:
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: gasket: using octal permissions instead of symbolic permissions
2020-04-02 13:18 ` Gokce Kuler
2020-04-02 13:30 ` Greg KH
@ 2020-04-02 13:54 ` Julia Lawall
1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2020-04-02 13:54 UTC (permalink / raw)
To: Gokce Kuler
Cc: Julia Lawall, Greg KH, outreachy-kernel, Rob Springer,
Todd Poynor, benchan
[-- Attachment #1: Type: text/plain, Size: 2677 bytes --]
On Thu, 2 Apr 2020, Gokce Kuler wrote:
> Can I edit like #define GASKET_SYSFS_RO(_name,_permission_, _show_function, _attr_type) ?
Look at how others have used __ATTR_RO. What you propose does not look
right.
julia
>
> Julia Lawall <julia.lawall@inria.fr>, 2 Nis 2020 Per, 15:43 tarihinde şunu yazdı:
> On Thu, 2 Apr 2020, Gokce Kuler wrote:
>
> > checkpatch.pl did not show any warning about this. Can I add the permission head to __ATTR_RO() ?
>
> What do you mean by permission head?
>
> julia
>
> >
> > Greg KH <gregkh@linuxfoundation.org>, 1 Nis 2020 Çar, 08:56 tarihinde şunu yazdı:
> > On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> > > Since octal permissions is preffered to symbolic permissions,
> > > octal permissions is used.Problem found checkpatch.pl.
> > >
> > > Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> > > ---
> > > drivers/staging/gasket/gasket_sysfs.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> > > index 1d0eed6..28dc422 100644
> > > --- a/drivers/staging/gasket/gasket_sysfs.h
> > > +++ b/drivers/staging/gasket/gasket_sysfs.h
> > > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {
> > >
> > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> > > { \
> > > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> > > + .attr = __ATTR(_name, 0444, _show_function, NULL), \
> >
> > Why not use __ATTR_RO() instead?
> >
> > thanks,
> >
> > greg k-h
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to
> outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/outreachy-kernel/CAL9LiB%2BPSd68yRfkrbr9yHkShzuPceJHosvswETO1-w1zgkqFw%40mail.gmail.com.
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-02 13:54 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-31 23:09 [PATCH] staging: gasket: using octal permissions instead of symbolic permissions Gokce Kuler
2020-04-01 3:01 ` [Outreachy kernel] " Stefano Brivio
2020-04-01 5:56 ` Greg KH
2020-04-02 12:20 ` Gokce Kuler
2020-04-02 12:43 ` [Outreachy kernel] " Julia Lawall
2020-04-02 13:18 ` Gokce Kuler
2020-04-02 13:30 ` Greg KH
2020-04-02 13:54 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.