From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap: Handle memory allocation failure in readahead
Date: Wed, 1 Apr 2020 08:50:04 -0700 [thread overview]
Message-ID: <20200401155004.GA8331@infradead.org> (raw)
In-Reply-To: <20200401030421.17195-1-willy@infradead.org>
On Tue, Mar 31, 2020 at 08:04:21PM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> bio_alloc() can fail when we use GFP_NORETRY. If it does, allocate
> a bio large enough for a single page like mpage_readpages() does.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks ok - not because I'm a fan of the pattern, but because we have
a real bug and this seems to be the quickest fix and similar to the
mpage codebase..
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-04-01 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 3:04 [PATCH] iomap: Handle memory allocation failure in readahead Matthew Wilcox
2020-04-01 4:31 ` Darrick J. Wong
2020-04-01 11:23 ` Matthew Wilcox
2020-04-01 16:48 ` Darrick J. Wong
2020-04-01 16:58 ` Matthew Wilcox
2020-04-01 15:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401155004.GA8331@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.