From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH v2] nvme: inherit stable pages constraint in the mpath stack device
Date: Thu, 2 Apr 2020 09:52:00 +0200 [thread overview]
Message-ID: <20200402075200.GA15551@lst.de> (raw)
In-Reply-To: <469eb075-2a6f-3386-f843-90525590fcba@grimberg.me>
On Wed, Apr 01, 2020 at 12:11:09PM -0700, Sagi Grimberg wrote:
>> I think this needs to go into blk_queue_stack_limits instead, otherwise
>> we have the same problem with other stacking drivers.
>
> I thought about this, but the stack_limits has different variants
> (blk_stack_limits, bdev_stack_limits) but only the first takes a
> request_queue...
>
> I see that dm-table does roughly the same thing, drbd ignores it.
> In general, dm is doing a whole bunch of stacking limits/capabilities
> related stuff that are not involved in blk_stack_limits...
>
> I could theoretically add a flag to queue_limits to mirror this, is
> that what you are suggesting?
I guess we'll just go with your v4 patch for now and I'll see if I
can refactor this mess later..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] nvme: inherit stable pages constraint in the mpath stack device
Date: Thu, 2 Apr 2020 09:52:00 +0200 [thread overview]
Message-ID: <20200402075200.GA15551@lst.de> (raw)
In-Reply-To: <469eb075-2a6f-3386-f843-90525590fcba@grimberg.me>
On Wed, Apr 01, 2020 at 12:11:09PM -0700, Sagi Grimberg wrote:
>> I think this needs to go into blk_queue_stack_limits instead, otherwise
>> we have the same problem with other stacking drivers.
>
> I thought about this, but the stack_limits has different variants
> (blk_stack_limits, bdev_stack_limits) but only the first takes a
> request_queue...
>
> I see that dm-table does roughly the same thing, drbd ignores it.
> In general, dm is doing a whole bunch of stacking limits/capabilities
> related stuff that are not involved in blk_stack_limits...
>
> I could theoretically add a flag to queue_limits to mirror this, is
> that what you are suggesting?
I guess we'll just go with your v4 patch for now and I'll see if I
can refactor this mess later..
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-04-02 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 6:06 [PATCH v2] nvme: inherit stable pages constraint in the mpath stack device Sagi Grimberg
2020-04-01 6:33 ` Christoph Hellwig
2020-04-01 6:41 ` Sagi Grimberg
2020-04-01 9:05 ` Christoph Hellwig
2020-04-01 19:11 ` Sagi Grimberg
2020-04-01 19:11 ` Sagi Grimberg
2020-04-02 7:52 ` Christoph Hellwig [this message]
2020-04-02 7:52 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-04-02 5:44 Sagi Grimberg
2020-04-02 8:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402075200.GA15551@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.